Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version ansys/nexus folder #344

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Conversation

mariostieriansys
Copy link
Collaborator

As a requirement to support multiple versions of EnSight/PyEnSight on AnsysLab/OnScale Notebook we have the need to version the ansys/nexus folder in the nexus### distribution.

This PR reflects the changes needed in PyEnSight once the EnSight change is merged.

A fallback is provided if the version of EnSight being used is < 242

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5b199d6) 75.25% compared to head (53bc0f5) 75.28%.

Files Patch % Lines
src/ansys/pyensight/core/renderable.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   75.25%   75.28%   +0.03%     
==========================================
  Files          18       18              
  Lines        2849     2857       +8     
  Branches      517      518       +1     
==========================================
+ Hits         2144     2151       +7     
- Misses        543      544       +1     
  Partials      162      162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randallfrank
Copy link
Collaborator

randallfrank commented Jan 5, 2024

@mariostieriansys I'll let you decide on the order with which to commit these :).

@mariostieriansys mariostieriansys merged commit cca6a1a into main Jan 10, 2024
24 checks passed
@mariostieriansys mariostieriansys deleted the mostieri/nexus_ansys_versioning branch January 10, 2024 17:07
mariostieriansys added a commit that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants