Add Session API to check EnSight version #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a call on the Session object to make sure the EnSight version is at least some target.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
- Coverage 75.20% 75.13% -0.08%
==========================================
Files 18 18
Lines 2860 2888 +28
Branches 518 526 +8
==========================================
+ Hits 2151 2170 +19
- Misses 547 553 +6
- Partials 162 165 +3 ☔ View full report in Codecov by Sentry. |
mariostieriansys
requested changes
Jan 19, 2024
There was a problem hiding this comment.
@randallfrank wonderful!
Could you please add the same check with the same version on the create_particle/add_emitter/ functions in the parts utils?
Thanks!
Add formal version checks for create_particle* and add_emitter* calls.
@mariostieriansys I think I have this in now, please review. |
mariostieriansys
approved these changes
Jan 19, 2024
|
@randallfrank thanks! That's perfect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a call on the Session object to make sure the EnSight version is at least some target.