add temporary backdoor to allow ADR upgrade of jquery library #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
margalva
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Philip is working on an upgrade of the jquery libraries. As part of this upgrade, he is conveniently dropping the jquery version from the script.
This is causing a failure in the PyEnSight tests since one of the tests tries to launch the deep pixel renderable, which triggers a copy of the old jquery libs in the websocketserved directory of the running pyensight session.
This PR adds a backdoor where both the versioned and unversioned scripts are tried.
While this is not ideal, it will work so that Philip can let his PR in. Once merged, a second PR on PyEnSight could be created where instead of trying both the libraries, we can first check the backend EnSight version, and if it is at least 251, the jquery script to be copied will be the unversioned one, the versioned one otherwise