Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around issues with black material surfaces #471

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

randallfrank
Copy link
Collaborator

When possible, use the JSON description of the material to improve on the simpler protobuffer color scheme.

When possible, use the JSON description of the material to improve on the simpler protobuffer color scheme.
Remove '(s)' from the docs.
Copy link
Collaborator

@david-bremer david-bremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied 8 metallic materials to 8 rocky shapes, and they came through where one would expect, for all of the shapes defined by a mesh. They look a little different, but the base color differs, and the shininess comes through.

The color is not applied to the spheres, which use some other shader, so that is expected.

@randallfrank
Copy link
Collaborator Author

I applied 8 metallic materials to 8 rocky shapes, and they came through where one would expect, for all of the shapes defined by a mesh. They look a little different, but the base color differs, and the shininess comes through.

The color is not applied to the spheres, which use some other shader, so that is expected.

Your call @david-bremer if you want to handle spheres the same way. I only did triangles and went out of my way to avoid lines (on purpose).

@randallfrank randallfrank merged commit 3020856 into main Oct 30, 2024
25 checks passed
@randallfrank randallfrank deleted the fix/material_colors branch October 30, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants