-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around issues with black material surfaces #471
Conversation
When possible, use the JSON description of the material to improve on the simpler protobuffer color scheme.
Remove '(s)' from the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied 8 metallic materials to 8 rocky shapes, and they came through where one would expect, for all of the shapes defined by a mesh. They look a little different, but the base color differs, and the shininess comes through.
The color is not applied to the spheres, which use some other shader, so that is expected.
Your call @david-bremer if you want to handle spheres the same way. I only did triangles and went out of my way to avoid lines (on purpose). |
When possible, use the JSON description of the material to improve on the simpler protobuffer color scheme.