Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited examples in docstrings to use new API issue #552 #554

Merged
merged 4 commits into from
Aug 12, 2021

Conversation

jgd10
Copy link
Contributor

@jgd10 jgd10 commented Aug 11, 2021

Examples edited to use API where there were explicit errors being thrown
because the code wasn't recognized. All edited examples now run (and
have been tested) except for one matrix multiplication, which I will
raise a ticket for.

closes #552

Examples edited to use API where there were explicit errors being thrown
because the code wasn't recognised. All edited examples now run (and
have been tested) except for one matrix multiplication, which I will
raise a ticket for.
@jgd10 jgd10 requested a review from akaszynski August 11, 2021 14:51
@jgd10
Copy link
Contributor Author

jgd10 commented Aug 11, 2021

Do not merge, two examples were accidentally deleted when I created this PR.

@jgd10 jgd10 added the DO NOT MERGE Not ready to be merged yet label Aug 11, 2021
@jgd10 jgd10 removed the DO NOT MERGE Not ready to be merged yet label Aug 11, 2021
@jgd10
Copy link
Contributor Author

jgd10 commented Aug 11, 2021

Added files back; good to review & merge now!

This was referenced Aug 11, 2021
@akaszynski
Copy link
Collaborator

Docbuild should be fixed by #556. Merge the PR and then merge main and you should be good to go.

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. CI failure was due to docker failing to pull from github; other doc CI passed so I'm merging.

@akaszynski akaszynski merged commit 31127c5 into main Aug 12, 2021
@akaszynski akaszynski deleted the doc/examples_fix_issue_552 branch August 12, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange/incorrect docs examples in ansys.mapdl.core.math
2 participants