Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: code maintenance #949

Merged
merged 7 commits into from
Oct 23, 2024
Merged

chore: code maintenance #949

merged 7 commits into from
Oct 23, 2024

Conversation

dipinknair
Copy link
Collaborator

@dipinknair dipinknair commented Oct 16, 2024

  • remove duplicate functions
  • raise error instead of string

@github-actions github-actions bot added the maintenance Package and maintenance related label Oct 16, 2024
@dipinknair dipinknair marked this pull request as ready for review October 16, 2024 19:09
@dipinknair dipinknair requested a review from a team as a code owner October 16, 2024 19:09
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 16, 2024
@dipinknair dipinknair marked this pull request as draft October 16, 2024 20:05
@dipinknair dipinknair marked this pull request as ready for review October 22, 2024 21:23
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.10%. Comparing base (267df7d) to head (5bbecf0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #949      +/-   ##
==========================================
- Coverage   81.11%   81.10%   -0.01%     
==========================================
  Files          36       36              
  Lines        2309     2308       -1     
==========================================
- Hits         1873     1872       -1     
  Misses        436      436              

@dipinknair dipinknair merged commit 4153cc3 into main Oct 23, 2024
50 checks passed
@dipinknair dipinknair deleted the maint/code-quality branch October 23, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants