Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stubs CLI test #952

Merged
merged 13 commits into from
Oct 22, 2024
Merged

fix: stubs CLI test #952

merged 13 commits into from
Oct 22, 2024

Conversation

dipinknair
Copy link
Collaborator

@dipinknair dipinknair commented Oct 17, 2024

Tests run fine on 242, but fails in candidate because cli_impl takes mechanical path from local installed path. hence ansys-mechanical-ideconfig will throw exception.

  • Add check for available stubs version
  • Add necessary test

@dipinknair dipinknair requested a review from a team as a code owner October 17, 2024 19:28
@github-actions github-actions bot added bug Something isn't working documentation Improvements or additions to documentation labels Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.44%. Comparing base (4acf478) to head (82ee548).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #952      +/-   ##
==========================================
+ Coverage   81.05%   85.44%   +4.39%     
==========================================
  Files          36       36              
  Lines        2280     2309      +29     
==========================================
+ Hits         1848     1973     +125     
+ Misses        432      336      -96     

@dipinknair dipinknair changed the title fix: subs_cli test fix: subs cli test Oct 17, 2024
@klmcadams klmcadams changed the title fix: subs cli test fix: stubs CLI test Oct 22, 2024
@github-actions github-actions bot added the dependencies Related with project dependencies label Oct 22, 2024
@dipinknair dipinknair merged commit 267df7d into main Oct 22, 2024
78 checks passed
@dipinknair dipinknair deleted the fix/stubs_test branch October 22, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Related with project dependencies documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants