-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong type hints on SimAIClient #106
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
=======================================
Coverage 85.55% 85.55%
=======================================
Files 44 44
Lines 2630 2630
=======================================
Hits 2250 2250
Misses 380 380 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes makes sense, thanks ! Thought it was maybe an invisible*args
causing the issue but self
makes more sense.
Due to steal_kwargs_type not handling 'self'
And remove useless key frfom pyproject
835b8b1
to
aac1f4d
Compare
Fixes #103
The issue is that in:
The
self
arg is causing an issue as it is not present inClientConfig
.My fix:
Concatenate[Any, T]
: typeself
asAny
.We would need python >=3.12 to properly type
self
, using something like@steal_kwargs_type_on_method[SimAIClient, ClientConfig]()