Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix monitor_callback interface not respected in upload_file_with_presigned_post #32

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

awoimbee
Copy link
Collaborator

This function gave the whole MultipartEncoderMonitor to monitor_callback instead of just an int

@awoimbee awoimbee self-assigned this Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2dcddba) 79.45% compared to head (70db43e) 80.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   79.45%   80.00%   +0.55%     
==========================================
  Files          42       42              
  Lines        2166     2166              
==========================================
+ Hits         1721     1733      +12     
+ Misses        445      433      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tmpbeing tmpbeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thanks

src/ansys/simai/core/api/mixin.py Show resolved Hide resolved
@tmpbeing tmpbeing merged commit 1832aae into main Feb 19, 2024
32 checks passed
@tmpbeing tmpbeing deleted the aw/fix-monitor-callback-interface branch February 19, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants