Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/sc 17799/investigate potential get subset pysimai #36

Merged

Conversation

kliment-slice
Copy link
Collaborator

[sc-17799]
fix for pysimai bug on get_subset(); tested on dev1

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.29%. Comparing base (2d7d8bf) to head (d71cf90).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   80.00%   80.29%   +0.28%     
==========================================
  Files          42       42              
  Lines        2166     2187      +21     
==========================================
+ Hits         1733     1756      +23     
+ Misses        433      431       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@awoimbee awoimbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kliment-slice kliment-slice merged commit ea5494c into main Apr 11, 2024
31 checks passed
@kliment-slice kliment-slice deleted the bug/sc-17799/investigate-potential-get-subset-pysimai branch April 11, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants