Feat/tbrom pyvista 24r2 part2 (stacked on feat/tbrom_pyvista_24r2) #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
github-actions
bot
added
documentation
for more information, see https://pre-commit.ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
+ Coverage 87.56% 87.69% +0.12%
==========================================
Files 11 11
Lines 2461 2543 +82
==========================================
+ Hits 2155 2230 +75
- Misses 306 313 +7 |
skip the 'F401 'tqdm.tqdm' imported but unused' error from flake8
Closed
EDCarman
reviewed
Jan 8, 2024
Merged
refactor meshdata pyvista object
for more information, see https://pre-commit.ci
lboucin
reviewed
Jan 12, 2024
lboucin
approved these changes
Jan 15, 2024
examples/02-tbrom_examples/04-TBROM_CFD_mesh_based_visualization.py
Outdated
Show resolved
Hide resolved
examples/02-tbrom_examples/04-TBROM_CFD_mesh_based_visualization.py
Outdated
Show resolved
Hide resolved
examples/02-tbrom_examples/04-TBROM_CFD_mesh_based_visualization.py
Outdated
Show resolved
Hide resolved
examples/02-tbrom_examples/04-TBROM_CFD_mesh_based_visualization.py
Outdated
Show resolved
Hide resolved
lboucin
reviewed
Jan 16, 2024
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up of abandoned PR #126 (part 2) :
This PR introduces new capabilities regarding 3D field visualization
It adds the necessary dependencies and updates the CI workflow to install a DPF server when building the documentation and running the examples