Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table): fix wrong compare operator, remove input components for unary filter operators #1596

Merged
merged 13 commits into from
Jun 9, 2021

Conversation

anranruye
Copy link
Member

@anranruye anranruye commented Jun 3, 2021

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fixes #1595
Fixes #1606

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix filter wrong compare operator after remove one filter condition; remove input components for 'Is Null' and 'Is Not Null' filter operators
🇨🇳 Chinese 修复删除一个筛选条件后筛选器比较运算符错误的问题;移除Is Null和Is Not Null筛选条件的输入组件

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jun 3, 2021

Prepare preview

@anranruye anranruye changed the title fix(module:table): fix wrong compare operator fix(module:table): fix wrong compare operator, remove input components for unary filter operators Jun 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2021

Codecov Report

Merging #1596 (46d7ab4) into master (5dd3087) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1596   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         448     448           
  Lines       28612   28527   -85     
======================================
+ Misses      28612   28527   -85     
Impacted Files Coverage Δ
components/affix/Affix.razor.cs 0.00% <0.00%> (ø)
components/input-number/InputNumber.razor.cs 0.00% <ø> (ø)
components/table/Column.razor 0.00% <0.00%> (ø)
components/table/Column.razor.cs 0.00% <0.00%> (ø)
components/table/TableFilter.cs 0.00% <0.00%> (ø)
components/table/TableModels/FilterModel.cs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 886ba9d...46d7ab4. Read the comment docs.

@anranruye anranruye requested a review from ElderJames June 7, 2021 16:46
@ElderJames ElderJames merged commit e6abf0b into ant-design-blazor:master Jun 9, 2021
@pr-triage pr-triage bot removed the PR: unreviewed label Jun 9, 2021
@pr-triage pr-triage bot added the PR: merged label Jun 9, 2021
@anranruye anranruye deleted the FixWrongOperator branch June 12, 2021 02:32
ElderJames added a commit that referenced this pull request Jun 18, 2021
* test: DateHelperTests was in the wrong dir (#1529)

* fix(module: radio): add defaultChecked and defaultValue (#1494)

* fix(module: radio): add defaultChecked and defaultValue

* add tests

* add test for radio group

* feat: Added locale es-ES (#1534)

* fix(module: locale): add missing 'filterOptions' node to german locale file (#1562)

* docs(module: table): update ‘fork official sample’ demo (#1544)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: npuNumber): include parser in value evaluation (#1567)

* fix(module: input): fix & feat & docs & tests: Input general fixes (#1530)

* docs(module:input): api correction & comments

* fix(module:input): clear icon in sync with antD

* fix(module:input): add parameter bordered

* fix(module:textarea): add parameter ShowCounter

* fix(module:input): Focus with behaviors

* docs: add missing docs, rearrange order

* fix(module:search): update to match new standard look

doc(module:search): add API & demos

* fix(module:inputgroup): override style to remove whitespace\
docs: same as react

* fix(module:inputpassword): support custom icon
docs: same as react

* fix(module:input): add blur method
docs: add blur method

* fix(module:input): add readonly parameter

* tests

* fix

* fix(module:input): sequence correction

* Update components/core/Base/AntComponentBase.cs

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* review fixes

* fix: clean-up

* tests: fix missing mock

* fix: focus

* fix(module:input): bind clear button to _inputValue

* tests: clear button show/hide

* tests: package update

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: drawer): OffsetX and offsetY do not work (#1435) (#1448)

* fix(module: drawer): OffsetX and offsetY do not work (#1435)

* docs: demo update

* fix: Placement is switched to the relative direction, the animation appears

* fix: the bug of closing animation missed

* fix: incorrect animation

* fix: different behaviors in WASM and Server side

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* docs: Added essential step in get started procedure (#1579)

* Added essential step in get started procedure

The article is missing the dependency registration. If these dependencies are not registered, the library couldn't be used (at least in my case).

* Update getting-started.en-US.md

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* docs: document improvement (#1578)

* fix the ordering of menu items

* add ueditor link

* fix icon document search style

* fix affix width for side menu

* add faq doc

* feat(module: datepicker): Picker clear button event (#1586)

* feat(module:datepicker): add OnClearClick eventcallback

* docs(module:datepicker): format docs has same behavior as react docs

* fix: adjust code to match net 3.1

* fix: eventcallback name fix

* Update site/AntDesign.Docs/Demos/Components/DatePicker/doc/index.zh-CN.md

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: dropdown): align with react (#1588)

* fix(module:dropdownbutton): align with react version

* doc(module:dropdownbutton): align with react docs

* fix(module: table): fix can not close filter by confirm button (#1602)

* fix(module: table): fix filter icon wrong highlight, fix filter behavior when there is no input value (#1592)

* fix(module:table): fix filter icon wrong highlight

* Update Column.razor

* fix(module:table): fix filter for no input

* fix(module: table): fix filter not applied (#1594)

* fix(module: InputNumber): fix error when blur (#1612)

* fix(affix): remove wrong event listeners (#1616)

* fix(module: table): fix wrong compare operator, remove input components for unary filter operators (#1596)

* fix(module:table): fix wrong compare operator

* remove whitespace

* fix(module:table): remove input component for 'is null' and 'is not null' table filter

* Update Column.razor

* fix(module:table): allow remove first filter

* remove whitespace

* Update Column.razor

* Update Column.razor

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: dropdown): dropdown button missing properties & docs fix for Dropdown & Button (#1609)

* fix:fix(module:dropdownbutton): add regular button behaviors and properties

* fix(module:button): add text type & docs

* docs(module:dropdown): version correction

* fix(module:overlay): re-add IsButton parameter

* fix: add xml comment to public methods

* fix(module:overlay): add xml documentation

* fix(module:dropdown): chrome block button force

* fix(module:button): remove Search parameter

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: datepicker): in form behavior (#1617)

* i18n: Add missing elements to Dutch locales (#1624)

* chore(ci): fix coverage report uploading (#1614)

* chore(ci): fix coverage report uploading

* continue when fail to upload

* docs: update modal and drawer docs (#1625)

* docs: update modal docs

* docs: modify DropdownInDrawer

* docs: update demo for DrawerService and ModalService

* fix(module: modal): Modal dialogs not showing anymore (#1635)

* Fix issue #1634 - Modal dialogs not showing anymore

* Removed unnecessary Search from ButtonProps as part of #1634 fix - Modal dialogs not showing anymore

* fix(module: table): fix selection clear (#1632)

* fix(module:table): fix selection issues

* allow SetSeletion(null) when there is not a Selection column

* allow change selection by setting RowDate.Selected

* fix(module: checkbox): fix checkbox group in-form behavior (#1637)

* fix(module: image): fix the style property position (#1642)

* fix(module: tag): Issue solved & align with react antd & tests (#1631)

* fix(module:tag): close does not trigger onclick

add custom color handling
add animation handling
add status tags

* docs(module:tag): align with react antd

* tests(module:tag): add basic tests

* fix: style fixes

* fix: remove default animation; add custom animation demo

* fix: remove ExtraCls and use Class from base

* Update components/tag/Tag.razor

* clear the open animate after tag opened

* translate demo docs

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* changelog 0.8.2 (#1649)

* add Visible back to Tag.razor.cs

* Update SearchLoading.razor and idnex.en-US.md

* Update index.zh-CN.md

Co-authored-by: 笨木头 <musicvs@163.com>
Co-authored-by: James Yeung <shunjiey@hotmail.com>
Co-authored-by: Magehernan <magehernan@gmail.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: black-snake <black-snake@users.noreply.github.com>
Co-authored-by: Gregory Loones <40325447+gregloones@users.noreply.github.com>
Co-authored-by: Razvan Predescu <rzvdaniel@gmail.com>
ElderJames added a commit that referenced this pull request Apr 23, 2022
…ts for unary filter operators (#1596)

* fix(module:table): fix wrong compare operator

* remove whitespace

* fix(module:table): remove input component for 'is null' and 'is not null' table filter

* Update Column.razor

* fix(module:table): allow remove first filter

* remove whitespace

* Update Column.razor

* Update Column.razor

Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Apr 23, 2022
* test: DateHelperTests was in the wrong dir (#1529)

* fix(module: radio): add defaultChecked and defaultValue (#1494)

* fix(module: radio): add defaultChecked and defaultValue

* add tests

* add test for radio group

* feat: Added locale es-ES (#1534)

* fix(module: locale): add missing 'filterOptions' node to german locale file (#1562)

* docs(module: table): update ‘fork official sample’ demo (#1544)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: npuNumber): include parser in value evaluation (#1567)

* fix(module: input): fix & feat & docs & tests: Input general fixes (#1530)

* docs(module:input): api correction & comments

* fix(module:input): clear icon in sync with antD

* fix(module:input): add parameter bordered

* fix(module:textarea): add parameter ShowCounter

* fix(module:input): Focus with behaviors

* docs: add missing docs, rearrange order

* fix(module:search): update to match new standard look

doc(module:search): add API & demos

* fix(module:inputgroup): override style to remove whitespace\
docs: same as react

* fix(module:inputpassword): support custom icon
docs: same as react

* fix(module:input): add blur method
docs: add blur method

* fix(module:input): add readonly parameter

* tests

* fix

* fix(module:input): sequence correction

* Update components/core/Base/AntComponentBase.cs

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* review fixes

* fix: clean-up

* tests: fix missing mock

* fix: focus

* fix(module:input): bind clear button to _inputValue

* tests: clear button show/hide

* tests: package update

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: drawer): OffsetX and offsetY do not work (#1435) (#1448)

* fix(module: drawer): OffsetX and offsetY do not work (#1435)

* docs: demo update

* fix: Placement is switched to the relative direction, the animation appears

* fix: the bug of closing animation missed

* fix: incorrect animation

* fix: different behaviors in WASM and Server side

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* docs: Added essential step in get started procedure (#1579)

* Added essential step in get started procedure

The article is missing the dependency registration. If these dependencies are not registered, the library couldn't be used (at least in my case).

* Update getting-started.en-US.md

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* docs: document improvement (#1578)

* fix the ordering of menu items

* add ueditor link

* fix icon document search style

* fix affix width for side menu

* add faq doc

* feat(module: datepicker): Picker clear button event (#1586)

* feat(module:datepicker): add OnClearClick eventcallback

* docs(module:datepicker): format docs has same behavior as react docs

* fix: adjust code to match net 3.1

* fix: eventcallback name fix

* Update site/AntDesign.Docs/Demos/Components/DatePicker/doc/index.zh-CN.md

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: dropdown): align with react (#1588)

* fix(module:dropdownbutton): align with react version

* doc(module:dropdownbutton): align with react docs

* fix(module: table): fix can not close filter by confirm button (#1602)

* fix(module: table): fix filter icon wrong highlight, fix filter behavior when there is no input value (#1592)

* fix(module:table): fix filter icon wrong highlight

* Update Column.razor

* fix(module:table): fix filter for no input

* fix(module: table): fix filter not applied (#1594)

* fix(module: InputNumber): fix error when blur (#1612)

* fix(affix): remove wrong event listeners (#1616)

* fix(module: table): fix wrong compare operator, remove input components for unary filter operators (#1596)

* fix(module:table): fix wrong compare operator

* remove whitespace

* fix(module:table): remove input component for 'is null' and 'is not null' table filter

* Update Column.razor

* fix(module:table): allow remove first filter

* remove whitespace

* Update Column.razor

* Update Column.razor

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: dropdown): dropdown button missing properties & docs fix for Dropdown & Button (#1609)

* fix:fix(module:dropdownbutton): add regular button behaviors and properties

* fix(module:button): add text type & docs

* docs(module:dropdown): version correction

* fix(module:overlay): re-add IsButton parameter

* fix: add xml comment to public methods

* fix(module:overlay): add xml documentation

* fix(module:dropdown): chrome block button force

* fix(module:button): remove Search parameter

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: datepicker): in form behavior (#1617)

* i18n: Add missing elements to Dutch locales (#1624)

* chore(ci): fix coverage report uploading (#1614)

* chore(ci): fix coverage report uploading

* continue when fail to upload

* docs: update modal and drawer docs (#1625)

* docs: update modal docs

* docs: modify DropdownInDrawer

* docs: update demo for DrawerService and ModalService

* fix(module: modal): Modal dialogs not showing anymore (#1635)

* Fix issue #1634 - Modal dialogs not showing anymore

* Removed unnecessary Search from ButtonProps as part of #1634 fix - Modal dialogs not showing anymore

* fix(module: table): fix selection clear (#1632)

* fix(module:table): fix selection issues

* allow SetSeletion(null) when there is not a Selection column

* allow change selection by setting RowDate.Selected

* fix(module: checkbox): fix checkbox group in-form behavior (#1637)

* fix(module: image): fix the style property position (#1642)

* fix(module: tag): Issue solved & align with react antd & tests (#1631)

* fix(module:tag): close does not trigger onclick

add custom color handling
add animation handling
add status tags

* docs(module:tag): align with react antd

* tests(module:tag): add basic tests

* fix: style fixes

* fix: remove default animation; add custom animation demo

* fix: remove ExtraCls and use Class from base

* Update components/tag/Tag.razor

* clear the open animate after tag opened

* translate demo docs

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* changelog 0.8.2 (#1649)

* add Visible back to Tag.razor.cs

* Update SearchLoading.razor and idnex.en-US.md

* Update index.zh-CN.md

Co-authored-by: 笨木头 <musicvs@163.com>
Co-authored-by: James Yeung <shunjiey@hotmail.com>
Co-authored-by: Magehernan <magehernan@gmail.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: black-snake <black-snake@users.noreply.github.com>
Co-authored-by: Gregory Loones <40325447+gregloones@users.noreply.github.com>
Co-authored-by: Razvan Predescu <rzvdaniel@gmail.com>
ElderJames added a commit that referenced this pull request Apr 30, 2022
…ts for unary filter operators (#1596)

* fix(module:table): fix wrong compare operator

* remove whitespace

* fix(module:table): remove input component for 'is null' and 'is not null' table filter

* Update Column.razor

* fix(module:table): allow remove first filter

* remove whitespace

* Update Column.razor

* Update Column.razor

Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Apr 30, 2022
* test: DateHelperTests was in the wrong dir (#1529)

* fix(module: radio): add defaultChecked and defaultValue (#1494)

* fix(module: radio): add defaultChecked and defaultValue

* add tests

* add test for radio group

* feat: Added locale es-ES (#1534)

* fix(module: locale): add missing 'filterOptions' node to german locale file (#1562)

* docs(module: table): update ‘fork official sample’ demo (#1544)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: npuNumber): include parser in value evaluation (#1567)

* fix(module: input): fix & feat & docs & tests: Input general fixes (#1530)

* docs(module:input): api correction & comments

* fix(module:input): clear icon in sync with antD

* fix(module:input): add parameter bordered

* fix(module:textarea): add parameter ShowCounter

* fix(module:input): Focus with behaviors

* docs: add missing docs, rearrange order

* fix(module:search): update to match new standard look

doc(module:search): add API & demos

* fix(module:inputgroup): override style to remove whitespace\
docs: same as react

* fix(module:inputpassword): support custom icon
docs: same as react

* fix(module:input): add blur method
docs: add blur method

* fix(module:input): add readonly parameter

* tests

* fix

* fix(module:input): sequence correction

* Update components/core/Base/AntComponentBase.cs

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* review fixes

* fix: clean-up

* tests: fix missing mock

* fix: focus

* fix(module:input): bind clear button to _inputValue

* tests: clear button show/hide

* tests: package update

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: drawer): OffsetX and offsetY do not work (#1435) (#1448)

* fix(module: drawer): OffsetX and offsetY do not work (#1435)

* docs: demo update

* fix: Placement is switched to the relative direction, the animation appears

* fix: the bug of closing animation missed

* fix: incorrect animation

* fix: different behaviors in WASM and Server side

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* docs: Added essential step in get started procedure (#1579)

* Added essential step in get started procedure

The article is missing the dependency registration. If these dependencies are not registered, the library couldn't be used (at least in my case).

* Update getting-started.en-US.md

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* docs: document improvement (#1578)

* fix the ordering of menu items

* add ueditor link

* fix icon document search style

* fix affix width for side menu

* add faq doc

* feat(module: datepicker): Picker clear button event (#1586)

* feat(module:datepicker): add OnClearClick eventcallback

* docs(module:datepicker): format docs has same behavior as react docs

* fix: adjust code to match net 3.1

* fix: eventcallback name fix

* Update site/AntDesign.Docs/Demos/Components/DatePicker/doc/index.zh-CN.md

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: dropdown): align with react (#1588)

* fix(module:dropdownbutton): align with react version

* doc(module:dropdownbutton): align with react docs

* fix(module: table): fix can not close filter by confirm button (#1602)

* fix(module: table): fix filter icon wrong highlight, fix filter behavior when there is no input value (#1592)

* fix(module:table): fix filter icon wrong highlight

* Update Column.razor

* fix(module:table): fix filter for no input

* fix(module: table): fix filter not applied (#1594)

* fix(module: InputNumber): fix error when blur (#1612)

* fix(affix): remove wrong event listeners (#1616)

* fix(module: table): fix wrong compare operator, remove input components for unary filter operators (#1596)

* fix(module:table): fix wrong compare operator

* remove whitespace

* fix(module:table): remove input component for 'is null' and 'is not null' table filter

* Update Column.razor

* fix(module:table): allow remove first filter

* remove whitespace

* Update Column.razor

* Update Column.razor

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: dropdown): dropdown button missing properties & docs fix for Dropdown & Button (#1609)

* fix:fix(module:dropdownbutton): add regular button behaviors and properties

* fix(module:button): add text type & docs

* docs(module:dropdown): version correction

* fix(module:overlay): re-add IsButton parameter

* fix: add xml comment to public methods

* fix(module:overlay): add xml documentation

* fix(module:dropdown): chrome block button force

* fix(module:button): remove Search parameter

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: datepicker): in form behavior (#1617)

* i18n: Add missing elements to Dutch locales (#1624)

* chore(ci): fix coverage report uploading (#1614)

* chore(ci): fix coverage report uploading

* continue when fail to upload

* docs: update modal and drawer docs (#1625)

* docs: update modal docs

* docs: modify DropdownInDrawer

* docs: update demo for DrawerService and ModalService

* fix(module: modal): Modal dialogs not showing anymore (#1635)

* Fix issue #1634 - Modal dialogs not showing anymore

* Removed unnecessary Search from ButtonProps as part of #1634 fix - Modal dialogs not showing anymore

* fix(module: table): fix selection clear (#1632)

* fix(module:table): fix selection issues

* allow SetSeletion(null) when there is not a Selection column

* allow change selection by setting RowDate.Selected

* fix(module: checkbox): fix checkbox group in-form behavior (#1637)

* fix(module: image): fix the style property position (#1642)

* fix(module: tag): Issue solved & align with react antd & tests (#1631)

* fix(module:tag): close does not trigger onclick

add custom color handling
add animation handling
add status tags

* docs(module:tag): align with react antd

* tests(module:tag): add basic tests

* fix: style fixes

* fix: remove default animation; add custom animation demo

* fix: remove ExtraCls and use Class from base

* Update components/tag/Tag.razor

* clear the open animate after tag opened

* translate demo docs

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* changelog 0.8.2 (#1649)

* add Visible back to Tag.razor.cs

* Update SearchLoading.razor and idnex.en-US.md

* Update index.zh-CN.md

Co-authored-by: 笨木头 <musicvs@163.com>
Co-authored-by: James Yeung <shunjiey@hotmail.com>
Co-authored-by: Magehernan <magehernan@gmail.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: black-snake <black-snake@users.noreply.github.com>
Co-authored-by: Gregory Loones <40325447+gregloones@users.noreply.github.com>
Co-authored-by: Razvan Predescu <rzvdaniel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants