Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): allow change both data source and value in one render period #1720

Conversation

anranruye
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fixes #1719
Fixes #1536

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English allow change both data source and value in one render period
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jul 8, 2021

Prepare preview

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #1720 (a820183) into master (1542d36) will increase coverage by 0.00%.
The diff coverage is 27.27%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1720   +/-   ##
=======================================
  Coverage   17.91%   17.91%           
=======================================
  Files         448      448           
  Lines       29250    29251    +1     
=======================================
+ Hits         5240     5241    +1     
  Misses      24010    24010           
Impacted Files Coverage Δ
components/select/Select.razor.cs 18.72% <27.27%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1542d36...a820183. Read the comment docs.

@ElderJames ElderJames requested a review from anddrzejb July 8, 2021 10:33
@ElderJames ElderJames merged commit 352b8ca into ant-design-blazor:master Jul 11, 2021
@anddrzejb
Copy link
Member

@ElderJames , @anranruye sorry guys for not responding 😞 . Currently I am both swamped & in the holiday fewer (short burst of high-intensity work split with pre-arranged holidays and this will probably last until end of August). Thanks for picking up my slack...

ElderJames added a commit that referenced this pull request Jul 16, 2021
* fix(module: grid): gutter adjustment on col initialize (#1653)

* feat(module: form): add advanced search demo (#1654)

* fix(module: tag): show pointer cursor when OnClick.HasDelegate (#1660)

* fix(module: form): fix input components inside customized form control (#1662)

* chore: enable AOT for docs site (#1656)

* Build AOT site

* remove package publish

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* fix(module: date-picker): fix low datetime error (#1663)

* fix(module: date-picker): Date picker blur/focus & regression tests (#1681)

* fix(module:datepicker): locale & blur issue fix

* tests(module:datepicker): add regression tests

* fix: focus is kept on picker false click & blur is applied when needed

* fix: tests

* fix(module: table): allow set filters after table initialization (#1667)

* fix(module:table): allow set filters after table initialization

* Update Column.razor.cs

* feat(module: form): use DisplayName attribute as the default FormItem Label (#1682)

* add. 如果没有设置FormItem的Label参数,则尝试使用绑定字段的DisplayName

* Update components/form/FormItem.razor.cs

Co-authored-by: 陈斌 <chenb@teleware.cn>
Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: space): fix space items behavior when they are inside `if` block (#1684)

* fix(module:space): fix space item margin

* remove Index parameter

* remove additional using

* Update Customize.razor space demo

* Update SpaceItem.razor

* fix(module: checkbox): remove redundant class (#1689)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): add PopupContainerSelector for filter and/or selector (#1687)

* fix(module:table): add PopupContainerSelector for filter and/or selector

* Update Column.razor

* fix(module: date-picker): fix date picker width (#1685)

* fix(module:date-picker): fix date picker width

* Update DatePickerBase.cs

* fix(module: checkbox): fix the test following up PR #1689 (#1699)

* fix(module: checkbox): fix tests

* fix testkit package

* feat(module: table): support expanding all items in table (#1695)

Add the ability to have all items in a table by setting  DefaultExpandAllRows to true.

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: upload): treat 2xx response codes success (#1705)

Treat all 2xx status codes as success in the upload module.

* fix aot build

* fix(module: overlay): better judge whether mouse is inside the trigger when click (#1692)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: locale-provider): add missing nodes default values (#1710)

* fix(i18n): russian locale resources additions (#1709)

* Russian locale resources additions

Based on #1707

* Change 'firstDayOfWeek' to 'Monday'

* fix(module: statistic): fix CountDown OnFinish callback exception(#1712) (#1714)

Calls to OnFinish callback now won't cause InvalidOperationException.

* fix(module: upload): UploadFileItem Provide default configuration: ignore case (#1717)

* feat(module: tabs): scroll over tab pane (#1581)

* feat(module: tabs): scroll over tab pane

* feat(module: tabs): drop down hide visible tabs

* clean up the code

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: select): allow change both data source and value in one render period (#1720)

* fix(module:select): allow change both datasource and value in one render period

* Update Select.razor.cs

* Update Select.razor.cs

* Update Select.razor.cs

* fix(module: dialog): Modal and Drawer render reducing and update document and demo  (#1701)

* fix(module: Modal&Drawer): render reducing and demo update

* docs(module: modal): add FAQ section

* docs: add English comments

* fix: wrong format in Modal_service_for_confirm.razor

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* chore: refactor the build process (#1729)

* refactor the build process

* add message

* changelog 0.8.3 (#1730)

* change 0.8.3

* Update CHANGELOG.zh-CN.md

* Update CHANGELOG.en-US.md

* fix build process for static web assets

* code style change

* code style change

* Update Tabs.razor.cs

* Update Tabs.razor.cs

* Update Tabs.razor.cs

Co-authored-by: James Yeung <shunjiey@hotmail.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: Newbe36524 <newbe36524@qq.com>
Co-authored-by: gmij <gmij@qq.com>
Co-authored-by: 陈斌 <chenb@teleware.cn>
Co-authored-by: Zonciu Liang <zonciu@zonciu.com>
Co-authored-by: Henrik Widlund <4659350+henrikwidlund@users.noreply.github.com>
Co-authored-by: kuznecovIT <62954135+kuznecovIT@users.noreply.github.com>
Co-authored-by: HexJacaranda <rbqlzg1937n@msn.com>
Co-authored-by: BeiYinZhiNian <1031622947@qq.com>
Co-authored-by: Brian Ding <brian_ding@outlook.com>
Co-authored-by: zxyao <zxyao145@gmail.com>
@anranruye anranruye deleted the FixSelectDataSourceAndValueBothChange branch July 17, 2021 17:46
ElderJames pushed a commit that referenced this pull request Apr 23, 2022
…ender period (#1720)

* fix(module:select): allow change both datasource and value in one render period

* Update Select.razor.cs

* Update Select.razor.cs

* Update Select.razor.cs
ElderJames pushed a commit that referenced this pull request Apr 30, 2022
…ender period (#1720)

* fix(module:select): allow change both datasource and value in one render period

* Update Select.razor.cs

* Update Select.razor.cs

* Update Select.razor.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants