Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: radio): support enum type for RadioGroup #1840

Merged
merged 1 commit into from
Aug 14, 2021

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English support enum type for RadioGroup ,use EnumRadioGroup
🇨🇳 Chinese 支持将枚举类型作为的选项,使用 EnumRadioGroup

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Aug 14, 2021

@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #1840 (0031097) into feature (44b25e0) will increase coverage by 23.51%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           feature    #1840       +/-   ##
============================================
+ Coverage     0.00%   23.51%   +23.51%     
============================================
  Files          476      494       +18     
  Lines        31183    23240     -7943     
  Branches         0      121      +121     
============================================
+ Hits             0     5464     +5464     
+ Misses       31183    17773    -13410     
- Partials         0        3        +3     
Impacted Files Coverage Δ
components/radio/EnumRadioGroup.cs 0.00% <0.00%> (ø)
components/core/Helpers/EnumHelper.cs 79.16% <80.00%> (+79.16%) ⬆️
components/card/Card.razor 0.00% <0.00%> (ø)
components/form/Form.razor 0.00% <0.00%> (ø)
components/rate/Rate.razor 0.00% <0.00%> (ø)
components/spin/Spin.razor 0.00% <0.00%> (ø)
components/tree/Tree.razor 0.00% <0.00%> (ø)
components/menu/MenuLink.cs 0.00% <0.00%> (ø)
components/menu/MenuMode.cs 0.00% <0.00%> (ø)
components/steps/Step.razor 0.00% <0.00%> (ø)
... and 438 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b25e0...0031097. Read the comment docs.

@ElderJames ElderJames merged commit 2395eb9 into feature Aug 14, 2021
@ElderJames ElderJames deleted the feat/radio-enum-group branch August 14, 2021 16:27
ElderJames added a commit that referenced this pull request Sep 14, 2021
* chore: sync ant-design v4.16.9 (#1782)

* refactor(module: tree): rename Checked/Dechecked methods to Check/Uncheck (#1792)

* feat(model: table): support responsive (#1802)

* feat(module: form): add properties Help, ValidateStatus and HasFeedback (#1807)

* Add properties Help, ValidateStatus and HasFeedback to FormItem

* refactor validation messages

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* feat(module: radio): add options for radio group (#1839)

* feat(module: radio): support enum type for `RadioGroup` (#1840)

* feat(module: image): support preview visible (#1842)

* feat(module: tree): add ChildContent for Tree and TreeNode (#1887)

* feat(module: tree): add ChildContent for Tree and TreeNode

Allow user set tree nodes directly.

* fix indent

* docs: Update the style to be compatible with antd 4.16 style. (#1893)

* docs: fix style

* fix logo font

* fix the color less

* feat(module: TreeSelect): add tree-select component 🚀 (#1773)

* fixed. Fix network error when requesting contributor list in local development environment

* fixed. Fix Chinese garbled code

* Update Dynamic.razor

* update. Adjust the base class of the select control to selectbase, and extract the common methods to prepare for tree select.

* fixed. Adjust the type of the parent control to selectbase

* tree-select完成基础编码工作。

* fix. 重新修订冲突解决时误删的变量

* fix. 修复在多选模式下无法显示初始值的bug

* fix some styles

* add. tree add Node UnSelect Event

* fix . Node Multiple Select Bug.

* fix Tree UnSelect invalid.

* fix. tree multiple select support.

* fix. select option sync tree node selected.

* fix. multiple select, old selected values has clear

* fix loop update exception

* 修复合并带来的冲突

* add. allow clear feat. but not finish.

* fix merge bug

* fix merge bug

* fix. supplementary notes

* update demo data with react demo

* add. 添加静态下拉树的能力,以及单选和多选的demo

* fix. 优化下拉显示树时,树选项的选中逻辑。

* fix demo

* fix. 静态下拉树时,出现错选的bug

* fix merge bugs.

* fix merge bugs.

* add. static dataObject Bind Support

* 将下拉树中,对偏平数据源的处理,移到simpleTreeSelect中

* fix ChildrenExpression

* feat: add dynamic component (#1703)

* feat: weakly-typed/dynamic component

* add TypeName support

* override BuildRenderTree instead of using a RenderFragment

* rename

* fix(module: timeline): label missing (#1941)

* chore: sync ant-design v4.16.13 (#1862)

Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: gmij <gmij@qq.com>
Co-authored-by: anranruye <hehewewe@hotmail.com>
Co-authored-by: Alan.Liu <lxyruanjian@126.com>
Co-authored-by: rabberbock <rabberbock@gmail.com>
Co-authored-by: Andrzej Bakun <anddrzejb@poczta.fm>
Co-authored-by: Chandan Rauniyar <chandankkrr@gmail.com>
Co-authored-by: Luke Parker [SSW] <10430890+Hona@users.noreply.github.com>
Co-authored-by: Tony Yip <tonyyip1969@gmail.com>
Co-authored-by: SmRiley <45205313+SmRiley@users.noreply.github.com>
ElderJames added a commit that referenced this pull request Apr 23, 2022
* chore: sync ant-design v4.16.9 (#1782)

* refactor(module: tree): rename Checked/Dechecked methods to Check/Uncheck (#1792)

* feat(model: table): support responsive (#1802)

* feat(module: form): add properties Help, ValidateStatus and HasFeedback (#1807)

* Add properties Help, ValidateStatus and HasFeedback to FormItem

* refactor validation messages

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* feat(module: radio): add options for radio group (#1839)

* feat(module: radio): support enum type for `RadioGroup` (#1840)

* feat(module: image): support preview visible (#1842)

* feat(module: tree): add ChildContent for Tree and TreeNode (#1887)

* feat(module: tree): add ChildContent for Tree and TreeNode

Allow user set tree nodes directly.

* fix indent

* docs: Update the style to be compatible with antd 4.16 style. (#1893)

* docs: fix style

* fix logo font

* fix the color less

* feat(module: TreeSelect): add tree-select component 🚀 (#1773)

* fixed. Fix network error when requesting contributor list in local development environment

* fixed. Fix Chinese garbled code

* Update Dynamic.razor

* update. Adjust the base class of the select control to selectbase, and extract the common methods to prepare for tree select.

* fixed. Adjust the type of the parent control to selectbase

* tree-select完成基础编码工作。

* fix. 重新修订冲突解决时误删的变量

* fix. 修复在多选模式下无法显示初始值的bug

* fix some styles

* add. tree add Node UnSelect Event

* fix . Node Multiple Select Bug.

* fix Tree UnSelect invalid.

* fix. tree multiple select support.

* fix. select option sync tree node selected.

* fix. multiple select, old selected values has clear

* fix loop update exception

* 修复合并带来的冲突

* add. allow clear feat. but not finish.

* fix merge bug

* fix merge bug

* fix. supplementary notes

* update demo data with react demo

* add. 添加静态下拉树的能力,以及单选和多选的demo

* fix. 优化下拉显示树时,树选项的选中逻辑。

* fix demo

* fix. 静态下拉树时,出现错选的bug

* fix merge bugs.

* fix merge bugs.

* add. static dataObject Bind Support

* 将下拉树中,对偏平数据源的处理,移到simpleTreeSelect中

* fix ChildrenExpression

* feat: add dynamic component (#1703)

* feat: weakly-typed/dynamic component

* add TypeName support

* override BuildRenderTree instead of using a RenderFragment

* rename

* fix(module: timeline): label missing (#1941)

* chore: sync ant-design v4.16.13 (#1862)

Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: gmij <gmij@qq.com>
Co-authored-by: anranruye <hehewewe@hotmail.com>
Co-authored-by: Alan.Liu <lxyruanjian@126.com>
Co-authored-by: rabberbock <rabberbock@gmail.com>
Co-authored-by: Andrzej Bakun <anddrzejb@poczta.fm>
Co-authored-by: Chandan Rauniyar <chandankkrr@gmail.com>
Co-authored-by: Luke Parker [SSW] <10430890+Hona@users.noreply.github.com>
Co-authored-by: Tony Yip <tonyyip1969@gmail.com>
Co-authored-by: SmRiley <45205313+SmRiley@users.noreply.github.com>
ElderJames added a commit that referenced this pull request Apr 30, 2022
* chore: sync ant-design v4.16.9 (#1782)

* refactor(module: tree): rename Checked/Dechecked methods to Check/Uncheck (#1792)

* feat(model: table): support responsive (#1802)

* feat(module: form): add properties Help, ValidateStatus and HasFeedback (#1807)

* Add properties Help, ValidateStatus and HasFeedback to FormItem

* refactor validation messages

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* feat(module: radio): add options for radio group (#1839)

* feat(module: radio): support enum type for `RadioGroup` (#1840)

* feat(module: image): support preview visible (#1842)

* feat(module: tree): add ChildContent for Tree and TreeNode (#1887)

* feat(module: tree): add ChildContent for Tree and TreeNode

Allow user set tree nodes directly.

* fix indent

* docs: Update the style to be compatible with antd 4.16 style. (#1893)

* docs: fix style

* fix logo font

* fix the color less

* feat(module: TreeSelect): add tree-select component 🚀 (#1773)

* fixed. Fix network error when requesting contributor list in local development environment

* fixed. Fix Chinese garbled code

* Update Dynamic.razor

* update. Adjust the base class of the select control to selectbase, and extract the common methods to prepare for tree select.

* fixed. Adjust the type of the parent control to selectbase

* tree-select完成基础编码工作。

* fix. 重新修订冲突解决时误删的变量

* fix. 修复在多选模式下无法显示初始值的bug

* fix some styles

* add. tree add Node UnSelect Event

* fix . Node Multiple Select Bug.

* fix Tree UnSelect invalid.

* fix. tree multiple select support.

* fix. select option sync tree node selected.

* fix. multiple select, old selected values has clear

* fix loop update exception

* 修复合并带来的冲突

* add. allow clear feat. but not finish.

* fix merge bug

* fix merge bug

* fix. supplementary notes

* update demo data with react demo

* add. 添加静态下拉树的能力,以及单选和多选的demo

* fix. 优化下拉显示树时,树选项的选中逻辑。

* fix demo

* fix. 静态下拉树时,出现错选的bug

* fix merge bugs.

* fix merge bugs.

* add. static dataObject Bind Support

* 将下拉树中,对偏平数据源的处理,移到simpleTreeSelect中

* fix ChildrenExpression

* feat: add dynamic component (#1703)

* feat: weakly-typed/dynamic component

* add TypeName support

* override BuildRenderTree instead of using a RenderFragment

* rename

* fix(module: timeline): label missing (#1941)

* chore: sync ant-design v4.16.13 (#1862)

Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: gmij <gmij@qq.com>
Co-authored-by: anranruye <hehewewe@hotmail.com>
Co-authored-by: Alan.Liu <lxyruanjian@126.com>
Co-authored-by: rabberbock <rabberbock@gmail.com>
Co-authored-by: Andrzej Bakun <anddrzejb@poczta.fm>
Co-authored-by: Chandan Rauniyar <chandankkrr@gmail.com>
Co-authored-by: Luke Parker [SSW] <10430890+Hona@users.noreply.github.com>
Co-authored-by: Tony Yip <tonyyip1969@gmail.com>
Co-authored-by: SmRiley <45205313+SmRiley@users.noreply.github.com>
ElderJames added a commit that referenced this pull request Sep 6, 2022
* chore: sync ant-design v4.16.9 (#1782)

* refactor(module: tree): rename Checked/Dechecked methods to Check/Uncheck (#1792)

* feat(model: table): support responsive (#1802)

* feat(module: form): add properties Help, ValidateStatus and HasFeedback (#1807)

* Add properties Help, ValidateStatus and HasFeedback to FormItem

* refactor validation messages

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* feat(module: radio): add options for radio group (#1839)

* feat(module: radio): support enum type for `RadioGroup` (#1840)

* feat(module: image): support preview visible (#1842)

* feat(module: tree): add ChildContent for Tree and TreeNode (#1887)

* feat(module: tree): add ChildContent for Tree and TreeNode

Allow user set tree nodes directly.

* fix indent

* docs: Update the style to be compatible with antd 4.16 style. (#1893)

* docs: fix style

* fix logo font

* fix the color less

* feat(module: TreeSelect): add tree-select component 🚀 (#1773)

* fixed. Fix network error when requesting contributor list in local development environment

* fixed. Fix Chinese garbled code

* Update Dynamic.razor

* update. Adjust the base class of the select control to selectbase, and extract the common methods to prepare for tree select.

* fixed. Adjust the type of the parent control to selectbase

* tree-select完成基础编码工作。

* fix. 重新修订冲突解决时误删的变量

* fix. 修复在多选模式下无法显示初始值的bug

* fix some styles

* add. tree add Node UnSelect Event

* fix . Node Multiple Select Bug.

* fix Tree UnSelect invalid.

* fix. tree multiple select support.

* fix. select option sync tree node selected.

* fix. multiple select, old selected values has clear

* fix loop update exception

* 修复合并带来的冲突

* add. allow clear feat. but not finish.

* fix merge bug

* fix merge bug

* fix. supplementary notes

* update demo data with react demo

* add. 添加静态下拉树的能力,以及单选和多选的demo

* fix. 优化下拉显示树时,树选项的选中逻辑。

* fix demo

* fix. 静态下拉树时,出现错选的bug

* fix merge bugs.

* fix merge bugs.

* add. static dataObject Bind Support

* 将下拉树中,对偏平数据源的处理,移到simpleTreeSelect中

* fix ChildrenExpression

* feat: add dynamic component (#1703)

* feat: weakly-typed/dynamic component

* add TypeName support

* override BuildRenderTree instead of using a RenderFragment

* rename

* fix(module: timeline): label missing (#1941)

* chore: sync ant-design v4.16.13 (#1862)

Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: gmij <gmij@qq.com>
Co-authored-by: anranruye <hehewewe@hotmail.com>
Co-authored-by: Alan.Liu <lxyruanjian@126.com>
Co-authored-by: rabberbock <rabberbock@gmail.com>
Co-authored-by: Andrzej Bakun <anddrzejb@poczta.fm>
Co-authored-by: Chandan Rauniyar <chandankkrr@gmail.com>
Co-authored-by: Luke Parker [SSW] <10430890+Hona@users.noreply.github.com>
Co-authored-by: Tony Yip <tonyyip1969@gmail.com>
Co-authored-by: SmRiley <45205313+SmRiley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Enable select and radio to support enumerated values
1 participant