Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use invariant culture for progress #2017

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

CAPCHIK
Copy link
Contributor

@CAPCHIK CAPCHIK commented Oct 12, 2021

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Progress use double ToString in interpolated strings, and in ru-RU culture for example double 50.9 converts as 50,9. That converting broke CSS, where ',' is service character.

  1. All formattable strings with double was wrapped with FormattableString.Invariant
  2. All string sums was replaced with StringBuilder Append
  3. ToRGB method now uses Regex to improve code readability

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Oct 12, 2021

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #2017 (2e06255) into master (f30303e) will increase coverage by 1.91%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2017      +/-   ##
==========================================
+ Coverage   25.51%   27.43%   +1.91%     
==========================================
  Files         488      511      +23     
  Lines       32111    24509    -7602     
  Branches        0      238     +238     
==========================================
- Hits         8192     6723    -1469     
+ Misses      23919    17750    -6169     
- Partials        0       36      +36     
Impacted Files Coverage Δ
components/progress/Progress.razor.cs 0.00% <0.00%> (ø)
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
components/tabs/TabPane.razor 86.66% <0.00%> (-6.20%) ⬇️
components/locale-provider/LocaleProvider.cs 64.06% <0.00%> (-5.94%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
components/input/TextArea.razor.cs 77.52% <0.00%> (-3.05%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Base/AntComponentBase.cs 46.42% <0.00%> (-2.96%) ⬇️
... and 422 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f30303e...2e06255. Read the comment docs.

@ElderJames ElderJames merged commit f958a5d into ant-design-blazor:master Oct 12, 2021
@CAPCHIK CAPCHIK deleted the fix/progress branch October 12, 2021 15:38
ElderJames pushed a commit that referenced this pull request Oct 16, 2021
* Use invariant culture for progress

* Use string interpolation instead StringBuilder
ElderJames pushed a commit that referenced this pull request Apr 23, 2022
* Use invariant culture for progress

* Use string interpolation instead StringBuilde
ElderJames pushed a commit that referenced this pull request Apr 30, 2022
* Use invariant culture for progress

* Use string interpolation instead StringBuilde
ElderJames pushed a commit that referenced this pull request Sep 6, 2022
* Use invariant culture for progress

* Use string interpolation instead StringBuilde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants