-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use invariant culture for progress #2017
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2017 +/- ##
==========================================
+ Coverage 25.51% 27.43% +1.91%
==========================================
Files 488 511 +23
Lines 32111 24509 -7602
Branches 0 238 +238
==========================================
- Hits 8192 6723 -1469
+ Misses 23919 17750 -6169
- Partials 0 36 +36
Continue to review full report at Codecov.
|
ElderJames
reviewed
Oct 12, 2021
ElderJames
approved these changes
Oct 12, 2021
ElderJames
approved these changes
Oct 12, 2021
ElderJames
pushed a commit
that referenced
this pull request
Oct 16, 2021
* Use invariant culture for progress * Use string interpolation instead StringBuilder
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
* Use invariant culture for progress * Use string interpolation instead StringBuilde
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
* Use invariant culture for progress * Use string interpolation instead StringBuilde
ElderJames
pushed a commit
that referenced
this pull request
Sep 6, 2022
* Use invariant culture for progress * Use string interpolation instead StringBuilde
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
Progress use
double ToString
in interpolated strings, and inru-RU
culture for example double50.9
converts as50,9
. That converting broke CSS, where ',' is service character.double
was wrapped with FormattableString.InvariantStringBuilder
Append
📝 Changelog
☑️ Self Check before Merge