Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: cascader): crashes when options is null (#563) #2105

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

noctis0430
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fix #563

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@dnfadmin
Copy link

dnfadmin commented Nov 11, 2021

CLA assistant check
All CLA requirements met.

@github-actions
Copy link

github-actions bot commented Nov 11, 2021

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #2105 (22372be) into master (b2d24d1) will increase coverage by 1.93%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2105      +/-   ##
==========================================
+ Coverage   27.93%   29.87%   +1.93%     
==========================================
  Files         492      515      +23     
  Lines       32509    24746    -7763     
  Branches        0      240     +240     
==========================================
- Hits         9083     7393    -1690     
+ Misses      23426    17317    -6109     
- Partials        0       36      +36     
Impacted Files Coverage Δ
components/cascader/Cascader.razor.cs 22.77% <100.00%> (+5.27%) ⬆️
components/core/Helpers/MemberPath/PathNode.cs 46.15% <0.00%> (-8.85%) ⬇️
components/core/Reflection/TypeDefined.cs 77.77% <0.00%> (-7.94%) ⬇️
components/input/InputGroup.razor.cs 87.50% <0.00%> (-6.95%) ⬇️
...ponents/date-picker/types/DatePickerPlaceholder.cs 22.72% <0.00%> (-4.20%) ⬇️
...ponents/core/Component/Overlay/type/TriggerType.cs 81.25% <0.00%> (-2.97%) ⬇️
components/core/Component/Overlay/Overlay.razor.cs 65.89% <0.00%> (-2.86%) ⬇️
components/core/Helpers/DateHelper.cs 80.00% <0.00%> (-2.71%) ⬇️
...nts/core/Component/Overlay/OverlayTrigger.razor.cs 53.47% <0.00%> (-2.50%) ⬇️
components/timeline/Timeline.razor.cs 63.21% <0.00%> (-2.24%) ⬇️
... and 424 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2d24d1...22372be. Read the comment docs.

@ElderJames ElderJames merged commit 2cf5db5 into ant-design-blazor:master Nov 12, 2021
@ElderJames
Copy link
Member

@noctis0430 Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cascader crashes when its empty (no data provided)
3 participants