fix(module:Tooltip) Tabindex #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies a tabindex to the wrapping div to help with focus driven from tabbing.
|
|
Codecov Report
@@ Coverage Diff @@
## master #2404 +/- ##
==========================================
+ Coverage 27.81% 29.75% +1.94%
==========================================
Files 496 519 +23
Lines 33146 25403 -7743
Branches 0 247 +247
==========================================
- Hits 9218 7559 -1659
+ Misses 23928 17804 -6124
- Partials 0 40 +40
Continue to review full report at Codecov.
|
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
…ip with tab key (#2404) Applies a tabindex to the wrapping div to help with focus driven from tabbing.
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
…ip with tab key (#2404) Applies a tabindex to the wrapping div to help with focus driven from tabbing.
15 tasks
ElderJames
pushed a commit
that referenced
this pull request
Sep 6, 2022
…ip with tab key (#2404) Applies a tabindex to the wrapping div to help with focus driven from tabbing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies a tabindex to the wrapping div to help with focus driven from tabbing.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
The Tooltip does not allow keyboard-based users to access their content because it's not a tab-able element. Adding a
tabindexto thedivthat's handling the events fixes this.divthat handles the event listeners.📝 Changelog
Users will be able to tab to elements that leverage the Tooltip component.
☑️ Self Check before Merge