Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(module:datepicker): correct culture not applied when manual input #2715

Merged

Conversation

Alexbits
Copy link
Contributor

@Alexbits Alexbits commented Sep 15, 2022

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#2714

💡 Background and solution

The culture of DatePicker is not taken into account when parsing manual input.

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Sep 15, 2022

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #2715 (f803297) into master (77f0021) will increase coverage by 1.42%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2715      +/-   ##
==========================================
+ Coverage   39.94%   41.36%   +1.42%     
==========================================
  Files         543      543              
  Lines       25697    25694       -3     
  Branches      260      260              
==========================================
+ Hits        10264    10628     +364     
+ Misses      15393    15026     -367     
  Partials       40       40              
Impacted Files Coverage Δ
components/date-picker/internal/DatePickerBase.cs 62.94% <100.00%> (ø)
components/date-picker/locale/FormatAnalyzer.cs 90.59% <100.00%> (ø)
components/select/Select.razor.cs 53.58% <0.00%> (+0.26%) ⬆️
components/select/SelectBase.cs 71.19% <0.00%> (+0.27%) ⬆️
components/input/Input.cs 67.25% <0.00%> (+0.35%) ⬆️
components/grid/Col.razor.cs 96.00% <0.00%> (+1.33%) ⬆️
components/core/Extensions/JSRuntimeExtensions.cs 53.33% <0.00%> (+3.33%) ⬆️
components/grid/Row.razor.cs 84.44% <0.00%> (+8.88%) ⬆️
components/core/Base/AntInputComponentBase.cs 73.33% <0.00%> (+11.42%) ⬆️
components/form/FormItem.razor 80.00% <0.00%> (+20.00%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ElderJames ElderJames linked an issue Sep 15, 2022 that may be closed by this pull request
Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ElderJames ElderJames merged commit 11dc934 into ant-design-blazor:master Sep 16, 2022
@Alexbits Alexbits deleted the fix/date-picker-input-culture branch September 16, 2022 05:46
YongQuan-dotnet pushed a commit to YongQuan-dotnet/ant-design-blazor that referenced this pull request Oct 9, 2022
ant-design-blazor#2715)

* fix:(module:datepicker): correct culture not applied when manual input

* fix:(module:datepicker): adjust FormatAnalyzer property access modifier
zxyao145 pushed a commit to zxyao145/ant-design-blazor that referenced this pull request Oct 16, 2022
ant-design-blazor#2715)

* fix:(module:datepicker): correct culture not applied when manual input

* fix:(module:datepicker): adjust FormatAnalyzer property access modifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with Datepicker culture "th-TH" when typing
2 participants