-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:(module:datepicker): correct culture not applied when manual input #2715
Merged
ElderJames
merged 2 commits into
ant-design-blazor:master
from
Alexbits:fix/date-picker-input-culture
Sep 16, 2022
Merged
fix:(module:datepicker): correct culture not applied when manual input #2715
ElderJames
merged 2 commits into
ant-design-blazor:master
from
Alexbits:fix/date-picker-input-culture
Sep 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2715 +/- ##
==========================================
+ Coverage 39.94% 41.36% +1.42%
==========================================
Files 543 543
Lines 25697 25694 -3
Branches 260 260
==========================================
+ Hits 10264 10628 +364
+ Misses 15393 15026 -367
Partials 40 40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ElderJames
approved these changes
Sep 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
YongQuan-dotnet
pushed a commit
to YongQuan-dotnet/ant-design-blazor
that referenced
this pull request
Oct 9, 2022
ant-design-blazor#2715) * fix:(module:datepicker): correct culture not applied when manual input * fix:(module:datepicker): adjust FormatAnalyzer property access modifier
zxyao145
pushed a commit
to zxyao145/ant-design-blazor
that referenced
this pull request
Oct 16, 2022
ant-design-blazor#2715) * fix:(module:datepicker): correct culture not applied when manual input * fix:(module:datepicker): adjust FormatAnalyzer property access modifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
#2714
💡 Background and solution
The culture of DatePicker is not taken into account when parsing manual input.
📝 Changelog
☑️ Self Check before Merge