Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(module: core): Add unit tests #2821

Merged
merged 7 commits into from
Oct 21, 2022
Merged

test(module: core): Add unit tests #2821

merged 7 commits into from
Oct 21, 2022

Conversation

LeaFrock
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Improve unit tests cover for core module
🇨🇳 Chinese 增加核心模块的单元测试覆盖

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Oct 19, 2022

@LeaFrock
Copy link
Contributor Author

Failed AntDesign.Tests.button.ButtonTests.Button_animation_when_cliked_end_after_some_time

I don't know why the CI fails. All tests work well in my local environment. I need your check for it, thanks! @ElderJames

@LeaFrock LeaFrock changed the title Improve unit tests cover for core module chore: Improve unit tests cover for core module Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 42.55% // Head: 41.25% // Decreases project coverage by -1.30% ⚠️

Coverage data is based on head (a0058ba) compared to base (75d108e).
Patch coverage: 41.86% of modified lines in pull request are covered.

❗ Current head a0058ba differs from pull request most recent head 743dadd. Consider uploading reports for the commit 743dadd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2821      +/-   ##
==========================================
- Coverage   42.55%   41.25%   -1.31%     
==========================================
  Files         544      544              
  Lines       25742    25763      +21     
  Branches      260      260              
==========================================
- Hits        10955    10628     -327     
- Misses      14747    15095     +348     
  Partials       40       40              
Impacted Files Coverage Δ
components/core/Helpers/ComponentBaseExtensions.cs 0.00% <0.00%> (ø)
components/core/Helpers/JsonElementHelper.cs 0.00% <0.00%> (ø)
components/core/Helpers/MomentHelper.cs 100.00% <ø> (+100.00%) ⬆️
components/table/Column.razor.cs 0.00% <0.00%> (ø)
components/core/Helpers/THelper.cs 27.02% <5.88%> (-12.98%) ⬇️
components/core/Helpers/ClassMapper.cs 95.00% <90.90%> (+1.25%) ⬆️
components/core/Helpers/ColorHelper.cs 100.00% <100.00%> (ø)
components/core/Helpers/EnumHelper.cs 100.00% <100.00%> (+20.83%) ⬆️
components/list/ListItemLayout.cs 0.00% <0.00%> (-100.00%) ⬇️
components/list/ListItem.razor 0.00% <0.00%> (-95.31%) ⬇️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LeaFrock LeaFrock changed the title chore: Improve unit tests cover for core module test(core): Improve unit tests cover for core module Oct 20, 2022
@LeaFrock LeaFrock changed the title test(core): Improve unit tests cover for core module test(module: core): Improve unit tests cover for core module Oct 20, 2022
@LeaFrock LeaFrock changed the title test(module: core): Improve unit tests cover for core module test(module: core): Add unit tests Oct 20, 2022
Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It help a lot!

@ElderJames ElderJames merged commit 9dcfb28 into ant-design-blazor:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants