Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: tabs): ReuseTabs occur error when the base url is not the default #3142

Merged
merged 2 commits into from
Feb 26, 2023
Merged

Conversation

dashiell-zhang
Copy link
Contributor

@dashiell-zhang dashiell-zhang commented Feb 26, 2023

fix 2860 ReuseTabs Switching tabs when the base url is not the default / causes url errors
fix #2860
Except the default path is "", any other page parameter must start with /, so just replace the empty character of the default path, otherwise a bug will occur when the BaseURL is not /

@github-actions
Copy link

github-actions bot commented Feb 26, 2023

@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Base: 46.07% // Head: 46.07% // No change to project coverage 👍

Coverage data is based on head (1da923d) compared to base (4784207).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3142   +/-   ##
=======================================
  Coverage   46.07%   46.07%           
=======================================
  Files         556      556           
  Lines       26630    26630           
  Branches      264      264           
=======================================
  Hits        12269    12269           
  Misses      14321    14321           
  Partials       40       40           
Impacted Files Coverage Δ
components/tabs/Reuse/ReuseTabs.razor.cs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ElderJames ElderJames changed the title fix 2860 ReuseTabs Switching tabs when the base url is not the defaul… fix(module: tabs): ReuseTabs occur error when the base url is not the default Feb 26, 2023
@ElderJames ElderJames merged commit 2430540 into ant-design-blazor:master Feb 26, 2023
@dashiell-zhang dashiell-zhang deleted the fix2860 branch February 27, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReuseTabs Switching tabs when the base url is not the default / causes url errors
2 participants