Change Calculation of Calendarweek for WeekPicker #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some languages have reserved letters in their Week. for example the german Week is Woche and the 'h' will be replaced by the hour resulting int 'Woc12e' or similar
|
|
|
@dotnet-policy-service agree |
ElderJames
approved these changes
Apr 7, 2023
|
Thanks for contribution @sebastian-wachsmuth ! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3214 +/- ##
==========================================
+ Coverage 46.10% 46.16% +0.06%
==========================================
Files 557 557
Lines 26621 26625 +4
Branches 266 266
==========================================
+ Hits 12273 12292 +19
+ Misses 14308 14293 -15
Partials 40 40
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
The WeekPicker is currently using DateHelper.GetWeekOfYear(DateTime date, DayOfWeek firstDay) for the calculation of the Week number. DateHelper is using the InvariantCulture.
FirstDayOfWeek of the InvariantCulture is Sunday
For example, for de-DE culture, the default value of FirstDayOfWeek is Monday
Additionaly CalendarWeekRule of InvariantCulture is FirstDay
For de-DE it is FirstFourDayWeek
those differences result in different Weeknumbers for both cultures.
For Example the 3rd April 2023 is Week 15 for Invariant and 14 for de-DE
To resolve this Issue we can use the CultureInfo Property of the DatePicker
Another Issue with the german Culture is the Translation for "Week" it contains an 'h' which is also a reserved letter for the time format and will be replaced with the current hour.
The fix for this is to escape the string with quotation marks
📝 Changelog
Change calculation of Week of Year for WeekPicker, changes the displayed WeekNumber in the DropDownPanel and in the SelectedValue display
☑️ Self Check before Merge