Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: tree): Multiple should not take effect when Ctrl is not pressed. #3350

Merged
merged 4 commits into from
Jul 13, 2023

Conversation

YongQuan-dotnet
Copy link
Collaborator

@YongQuan-dotnet YongQuan-dotnet commented Jul 11, 2023

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jul 11, 2023

@YongQuan-dotnet YongQuan-dotnet force-pushed the fix/TreeMultiple branch 5 times, most recently from 56055dc to f5627eb Compare July 11, 2023 21:48
@YongQuan-dotnet YongQuan-dotnet changed the title fix(tree): Multiple should not take effect when Ctrl is not pressed. fix(module: tree): Multiple should not take effect when Ctrl is not pressed. Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 40.74% and project coverage change: -0.02 ⚠️

Comparison is base (dbf8780) 45.36% compared to head (a20dd7c) 45.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3350      +/-   ##
==========================================
- Coverage   45.36%   45.34%   -0.02%     
==========================================
  Files         558      558              
  Lines       26807    26827      +20     
  Branches      267      267              
==========================================
+ Hits        12162    12166       +4     
- Misses      14605    14621      +16     
  Partials       40       40              
Impacted Files Coverage Δ
components/core/JsInterop/DomEventListener.cs 0.00% <0.00%> (ø)
components/tree-select/TreeSelect.razor 0.00% <0.00%> (ø)
components/tree/TreeNode.razor.cs 27.35% <0.00%> (-0.09%) ⬇️
components/tree/Tree.razor.cs 26.98% <55.00%> (+2.52%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@YongQuan-dotnet YongQuan-dotnet force-pushed the fix/TreeMultiple branch 2 times, most recently from 6e890a6 to 4c77361 Compare July 12, 2023 10:53
Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElderJames ElderJames merged commit 595a70f into ant-design-blazor:master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants