Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: select): EnumSelect throwing exception cause by nullable enum type #3859

Merged
merged 1 commit into from
May 12, 2024

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fixed #3858

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented May 11, 2024

Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.69%. Comparing base (8db23e8) to head (7556058).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3859      +/-   ##
==========================================
+ Coverage   43.47%   43.69%   +0.21%     
==========================================
  Files         579      576       -3     
  Lines       28303    28079     -224     
  Branches     5758     5712      -46     
==========================================
- Hits        12306    12269      -37     
+ Misses      14982    14808     -174     
+ Partials     1015     1002      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit 43b38b4 into master May 12, 2024
6 checks passed
@ElderJames ElderJames deleted the fix/select-nullable-enum branch May 12, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EnumSelect: Exception when binding to nullable enums
1 participant