Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: table): add built-in filter support for DateOnly & TimeOnly fields. #4034

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Jul 27, 2024

@ElderJames ElderJames force-pushed the feat/table-dateonly-filter branch from 8d88e97 to 0ebe3e6 Compare July 27, 2024 15:20
@ElderJames ElderJames force-pushed the feat/table-dateonly-filter branch from 0ebe3e6 to 94d5d73 Compare July 27, 2024 15:21
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 43.34%. Comparing base (0826e59) to head (2144287).
Report is 12 commits behind head on feature.

Files Patch % Lines
components/table/Filters/DateFieldFilterType.cs 0.00% 13 Missing ⚠️
components/table/Filters/FilterInputs.razor 0.00% 6 Missing ⚠️
components/table/Filters/FilterTypeResolver.cs 0.00% 2 Missing ⚠️
components/menu/Menu.razor.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           feature    #4034       +/-   ##
============================================
+ Coverage     1.43%   43.34%   +41.90%     
============================================
  Files          574      579        +5     
  Lines        29193    29529      +336     
  Branches      5742     5844      +102     
============================================
+ Hits           418    12798    +12380     
+ Misses       28735    15690    -13045     
- Partials        40     1041     +1001     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit c698616 into feature Jul 27, 2024
5 of 6 checks passed
@ElderJames ElderJames deleted the feat/table-dateonly-filter branch July 27, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant