Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: tabs): make it possible to work without setting keys of TabPane #4297

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Oct 22, 2024

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 1.41%. Comparing base (a8a05e0) to head (412c051).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
components/tabs/TabPane.razor.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #4297      +/-   ##
=========================================
- Coverage    1.41%   1.41%   -0.01%     
=========================================
  Files         589     589              
  Lines       30141   30142       +1     
  Branches     5966    5967       +1     
=========================================
  Hits          428     428              
- Misses      29672   29673       +1     
  Partials       41      41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit 95d424e into master Oct 22, 2024
5 of 6 checks passed
@ElderJames ElderJames deleted the fix/tabs-pane-without-key branch October 22, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant