Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix tooltip trigger type #22043

Merged
merged 4 commits into from
Mar 11, 2020
Merged

fix: fix tooltip trigger type #22043

merged 4 commits into from
Mar 11, 2020

Conversation

wzhudev
Copy link

@wzhudev wzhudev commented Mar 9, 2020

close #22010

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Update type definition of trigger property of tooltip, etc
🇨🇳 Chinese 更新 tooltip 等组件的 trigger 参数的定义

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/tooltip/index.en-US.md
View rendered components/tooltip/index.zh-CN.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Mar 9, 2020

@wzhudev
Copy link
Author

wzhudev commented Mar 9, 2020

Fix in the upstream repo react-component/tooltip#210

@zombieJ
Copy link
Member

zombieJ commented Mar 11, 2020

Hi @wendellhu95 ,
rc-tooltip has ts define itself. We can remove duplicated ts define instead.

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #22043 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22043   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files         306      306           
  Lines        7042     7042           
  Branches     1939     1929   -10     
=======================================
  Hits         6899     6899           
  Misses        143      143
Impacted Files Coverage Δ
components/tooltip/index.tsx 100% <ø> (ø) ⬆️
components/rate/index.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909bde6...f7bc49e. Read the comment docs.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f7bc49e:

Sandbox Source
antd reproduction template Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect typing for Tooltip trigger prop -- should be ActionType | ActionType[]
3 participants