Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(list): improve code #24280

Merged
merged 2 commits into from
May 19, 2020
Merged

chore(list): improve code #24280

merged 2 commits into from
May 19, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented May 19, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 19, 2020 •
edited
Loading

@codecov
Copy link

codecov bot commented May 19, 2020 •
edited
Loading

Codecov Report

Merging #24280 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24280      +/-   ##
==========================================
+ Coverage   98.81%   98.83%   +0.01%     
==========================================
  Files         363      363              
  Lines        7281     7279       -2     
  Branches     2006     2019      +13     
==========================================
- Hits         7195     7194       -1     
+ Misses         86       85       -1
Impacted Files Coverage Δ
components/list/Item.tsx 100.00% <ø> (ø)
components/list/index.tsx 97.95% <100.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd1088...adc86f6. Read the comment docs.

@hengkx hengkx requested a review from afc163 May 19, 2020 06:29
@hengkx hengkx merged commit baa56b6 into master May 19, 2020
@hengkx hengkx deleted the improve-code branch May 19, 2020 06:55
afc163 pushed a commit that referenced this pull request May 19, 2020
@hengkx @afc163
chore(list): improve code (#24280)
b94bfe7 
* chore(list): improve code

* Update index.tsx
afc163 added a commit that referenced this pull request May 19, 2020
@afc163 @hengkx
refactor: tree select style (#24291)
4feb186 
* chore(list): improve code (#24280)

* chore(list): improve code

* Update index.tsx

* refactor: tree select style code

* 🔒 lock antd-theme-generator to 1.2.2

mzohaibqc/antd-theme-generator#42

Co-authored-by: Tom Xu <ycxzhkx@gmail.com>
@chenshuai2144 chenshuai2144 mentioned this pull request May 23, 2020
Merged
@lgants lgants mentioned this pull request Jun 6, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hengkx @ant-design-bot @afc163