Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: horizontal menu in dark & dark #26062

Merged
merged 1 commit into from
Aug 7, 2020
Merged

fix: horizontal menu in dark & dark #26062

merged 1 commit into from
Aug 7, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Aug 6, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English Fix horizontal Menu darktheme style under dark theme.
🇨🇳 Chinese 修复水平 Menu 黑暗 theme 在暗黑主题下的样式。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@xrkffgg
Copy link
Member Author

xrkffgg commented Aug 6, 2020

@afc163 CI 这是咋了

@kerm1it
Copy link
Member

kerm1it commented Aug 6, 2020

应该是 npm 出问题了拉不到包

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2020

Size Change: +91 B (0%)

Total Size: 798 kB

Filename Size Change
./dist/antd.compact.min.css 64.8 kB +34 B (0%)
./dist/antd.dark.min.css 66.1 kB +25 B (0%)
./dist/antd.min.css 64.8 kB +32 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 317 kB 0 B
./dist/antd.min.js 285 kB 0 B

compressed-size-action

@xrkffgg
Copy link
Member Author

xrkffgg commented Aug 6, 2020

/rebase

2 similar comments
@afc163
Copy link
Member

afc163 commented Aug 7, 2020

/rebase

@kerm1it
Copy link
Member

kerm1it commented Aug 7, 2020

/rebase

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 7, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 7, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fa2dcc2:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #26062 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26062   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files         373      373           
  Lines        7315     7315           
  Branches     2044     2044           
=======================================
  Hits         7283     7283           
  Misses         32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ade6da...fa2dcc2. Read the comment docs.

@xrkffgg xrkffgg merged commit d1d23ac into master Aug 7, 2020
@xrkffgg xrkffgg deleted the fix-menu-dark branch August 7, 2020 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants