Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update rc-motion deps & fix ssr #26542

Merged
merged 3 commits into from
Sep 2, 2020
Merged

fix: Update rc-motion deps & fix ssr #26542

merged 3 commits into from
Sep 2, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 2, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #26519

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form with help make ssr un-sync issue.
🇨🇳 Chinese 修复 Form 使用 help 时出现的同构问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 2, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Sep 2, 2020

@@ -129,7 +129,7 @@
"rc-input-number": "~6.0.0",
"rc-mentions": "~1.4.0",
"rc-menu": "~8.5.2",
"rc-motion": "^1.0.0",
"rc-motion": "^1.1.1",
Copy link
Member

@afc163 afc163 Sep 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里用的是 ^,可能已经影响了之前的 antd 版本。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rc-motion 出来的时间不长,这次重构主要是改成 FC 解决 SSR 的问题。对过去影响不会很大。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: 发 minor 也是因为重构,没有添加新特性。

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 860e607:

Sandbox Source
antd reproduction template Configuration
fast-sea-qzu2q Issue #26519

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #26542 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26542   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         383      383           
  Lines        7343     7343           
  Branches     2003     2051   +48     
=======================================
  Hits         7325     7325           
  Misses         18       18           
Impacted Files Coverage Δ
components/_util/motion.tsx 83.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc950d9...860e607. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prop className did not match.
3 participants