Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adjust collapse arrow position align with first line #27363

Merged
merged 6 commits into from
Oct 26, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 26, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Align collapse arrow position with pro List

📝 Changelog

Language Changelog
🇺🇸 English Adjust Collapse arrow align with first line.
🇨🇳 Chinese 调整 Collapse 箭头位置和第一行文本对齐。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163
Copy link
Member

afc163 commented Oct 26, 2020

改动略大,feature 分支吧。

@zombieJ
Copy link
Member Author

zombieJ commented Oct 26, 2020

改动略大,feature 分支吧。

👌 这周就是 feature 了,其实没差。

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 26, 2020

@zombieJ zombieJ changed the base branch from master to feature October 26, 2020 02:40
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f935bd5:

Sandbox Source
antd reproduction template Configuration

@hengkx
Copy link
Member

hengkx commented Oct 26, 2020

这不是 分支 合并了吗 这个 title

@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #27363 into feature will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           feature    #27363   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7384      7383    -1     
  Branches      2026      2075   +49     
=========================================
- Hits          7384      7383    -1     
Impacted Files Coverage Δ
components/input/Search.tsx 100.00% <ø> (ø)
components/_util/hooks/useCombinedRefs.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0245e7...f935bd5. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Oct 26, 2020

UI 测试和 build preview 是不是用的同一台机器,现在 preview 页面出来的好慢。

@github-actions
Copy link
Contributor

Size Change: -19 B (0%)

Total Size: 791 kB

Filename Size Change
./dist/antd.compact.min.css 66.5 kB -1 B
./dist/antd.dark.min.css 67.8 kB -16 B (0%)
./dist/antd.min.css 66.5 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 314 kB 0 B
./dist/antd.min.js 277 kB 0 B

compressed-size-action

@zombieJ
Copy link
Member Author

zombieJ commented Oct 26, 2020

UI 测试和 build preview 是不是用的同一台机器,现在 preview 页面出来的好慢。

都是 Azure Pipeline。preview build 完就完了,UI 打 snapshot 会花些时间。

cc @shaodahong

@zombieJ zombieJ merged commit c373710 into feature Oct 26, 2020
@zombieJ zombieJ deleted the collapse-pos branch October 26, 2020 02:56
@afc163
Copy link
Member

afc163 commented Oct 26, 2020

@shaodahong 看看能不能隔开。

@shaodahong
Copy link
Member

UI 测试和 build preview 是不是用的同一台机器,现在 preview 页面出来的好慢。

都是 Azure Pipeline。preview build 完就完了,UI 打 snapshot 会花些时间。

他们之间是并行的,互不干扰

@shaodahong
Copy link
Member

看了下时间都差不多,差别不是很大,不过这个 UI 我准备改到 CIRCLECI 去,因为我看了下 azure pipeline 只有 PR 才会触发,master 基准没有

image

@xrkffgg
Copy link
Member

xrkffgg commented Oct 26, 2020

好快啊,又一个月了

07akioni pushed a commit that referenced this pull request Nov 7, 2020
* fix: border style of Input.Search when allowClear (#27325)

* fix: border style of Input.Search when allowClear

* fix css

* update

* change name

* docs: 4.7.3 changelog (#27350)

* docs: 4.7.3 changelog

* docs: Patch 27325

* chore: improve useCombinedRefs (#27352)

* docs: 📝 update introduce

* chore: fix API table border

* chore: Adjust collapse arrow position align with first line

Co-authored-by: xrk <xrkffgg@gmail.com>
Co-authored-by: Tom Xu <ycxzhkx@gmail.com>
Co-authored-by: afc163 <afc163@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants