Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): fix Dropdown.Button not correctly rendered in Modal footer #30328

Merged
merged 1 commit into from
Apr 28, 2021
Merged

fix(modal): fix Dropdown.Button not correctly rendered in Modal footer #30328

merged 1 commit into from
Apr 28, 2021

Conversation

Map1en
Copy link
Contributor

@Map1en Map1en commented Apr 27, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #30317

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Dropdown.Button broken style when inside Modal footer.
🇨🇳 Chinese 修正 Modal footer 放置里 Dropdown.Button 的样式错乱问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

Prepare preview

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #30328 (b12c505) into master (4951b59) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #30328   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7522      7522           
  Branches      2105      2105           
=========================================
  Hits          7522      7522           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4951b59...b12c505. Read the comment docs.

@afc163 afc163 changed the title fix(modal): fix dropdown-btn not correctly rendered in modal footer fix(modal): fix Dropdown.Button not correctly rendered in Modal footer Apr 28, 2021
@afc163 afc163 merged commit 579e3c5 into ant-design:master Apr 28, 2021
@Map1en Map1en deleted the fix-dropdown-btn-in-modal-footer branch April 28, 2021 04:55
@zombieJ zombieJ mentioned this pull request Apr 30, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown.Button not correctly rendered in Modal footer
2 participants