Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : Switch component in typescript throws error for 'id' attribute #32237

Merged
merged 1 commit into from
Sep 19, 2021

Conversation

M-ZubairAhmed
Copy link
Contributor

@M-ZubairAhmed M-ZubairAhmed commented Sep 19, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #32203

💡 Background and solution

  • Adds optional 'id' attribute to switch component

📝 Changelog

Language Changelog
🇺🇸 English Allows 'id' optional prop for Switch
🇨🇳 Chinese 允许"id"可选道具用于Switch

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2021

@codecov
Copy link

codecov bot commented Sep 19, 2021

Codecov Report

Merging #32237 (1ac7061) into master (8467fdc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #32237   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          414       414           
  Lines         7571      7571           
  Branches      2125      2125           
=========================================
  Hits          7571      7571           
Impacted Files Coverage Δ
components/switch/index.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8467fdc...1ac7061. Read the comment docs.

@afc163 afc163 merged commit 0d670da into ant-design:master Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch component in typescript throws error for 'id' attribute
2 participants