Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: input token #44325

Merged
merged 7 commits into from
Aug 22, 2023
Merged

feat: input token #44325

merged 7 commits into from
Aug 22, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Aug 21, 2023

  • feat: input token
  • feat: input number token
  • feat: input token

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Migrate Input less variables to Component Token
🇨🇳 Chinese 迁移 Input 组件 less 变量到组件 Token

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 161b037

The pull request refactors the style modules of several input-related components (Input, InputNumber, Mentions, and Pagination) to use the new shared component tokens and input tokens, which provide more consistent and customizable style properties. The pull request also updates the theme interface and the migration documents to reflect the changes in the Input component style tokens.

🔍 Walkthrough

🤖 Generated by Copilot at 161b037

  • Refactor the Input component to use the new SharedComponentToken and SharedInputToken types for common properties of input components (link,link,link,link,link,link,link,link,link,link,link,link)
  • Update the InputNumber component to extend the SharedComponentToken and SharedInputToken types and add new token properties for the handle buttons (link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link)
  • Update the Mentions component to extend the SharedComponentToken and SharedInputToken types and use the new token properties for padding (link,link,link,link,link,link,link)
  • Update the Pagination component to extend the SharedComponentToken and SharedInputToken types (link,link,link)
  • Update the ComponentTokenMap interface to include the InputComponentToken type (link,link)
  • Remove the unused initInputToken import from the typography/style/mixins.ts file and use the global token property for padding (link,link)
  • Add a new section for the Input component in the migrate-less-variables.en-US.md and migrate-less-variables.zh-CN.md documents, to list the mapping of the less variables to the component tokens and the notes for the migration (link,link)

@stackblitz
Copy link

stackblitz bot commented Aug 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 389.78 KB (+48 B 🔺)
./dist/antd-with-locales.min.js 448.66 KB (+47 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Aug 21, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 14 changes Aug 21, 2023, 2:14 PM

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8e7d02c) 100.00% compared to head (4c41a4f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #44325   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          663       663           
  Lines        11285     11287    +2     
  Branches      3049      3049           
=========================================
+ Hits         11285     11287    +2     
Files Changed Coverage Δ
components/pagination/style/index.ts 100.00% <ø> (ø)
components/calendar/style/index.ts 100.00% <100.00%> (ø)
components/date-picker/style/index.ts 100.00% <100.00%> (ø)
components/input-number/style/index.ts 100.00% <100.00%> (ø)
components/input/style/index.ts 100.00% <100.00%> (ø)
components/mentions/style/index.ts 100.00% <100.00%> (ø)
components/typography/style/mixins.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc
Copy link
Member Author

MadCcc commented Aug 22, 2023

argos 预期变化,以前的紧凑模式下有些问题
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants