Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: code optimization #50116

Merged
merged 1 commit into from
Jul 28, 2024
Merged

type: code optimization #50116

merged 1 commit into from
Jul 28, 2024

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Jul 28, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

  1. useColumnIcons 中使用 React.useMemo 缓存返回值(另一方面如果不用监听属性的话,这个 hook 就失去了 hook 的意义,只能算是一个普通的 util 方法)
  2. localUseToken 重命名为 useLocalToken(根据 hook 的原则,应该以 use 开头命名)
  3. any 类型替换为 GetCompUnitless
Language Changelog
🇺🇸 English type: code optimization
🇨🇳 Chinese type: code optimization

Copy link

stackblitz bot commented Jul 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jul 28, 2024

👁 Visual Regression Report for PR #50116 Passed ✅

🎯 Target branch: master (e8fa593)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Jul 28, 2024

Preview is ready

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 342.39 KB (+15 B 🔺)
./dist/antd-with-locales.min.js 392.85 KB (-22 B 🔽)

Copy link

pkg-pr-new bot commented Jul 28, 2024

Copy link

codecov bot commented Jul 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (e8fa593) to head (3cfaf04).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #50116   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         746      746           
  Lines       12920    12921    +1     
  Branches     3371     3371           
=======================================
+ Hits        12919    12920    +1     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 836d1bb into master Jul 28, 2024
85 checks passed
@afc163 afc163 deleted the GetCompUnitless-type branch July 28, 2024 17:31
linxianxi pushed a commit to linxianxi/ant-design that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants