Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(card): use card semantic-dom instead of table #50390

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

thinkasany
Copy link
Contributor

@thinkasany thinkasany commented Aug 13, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  1. 移除了### Card,让默认的card参数直接变成api的参数,这么做的原因有俩,1、参照drawer文档和其他地方做的修正 2、为了能够点击Record<SemanticDOM, string> 跳转到## Semantic DOM, 不这么改好像跳不了

  2. Semantic DOM 预览的这个其他组件都有,比原来的列表展示更好用,所以也想为card组件添加上。

image

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English docs(card): add card semantic
🇨🇳 Chinese docs(card): 增加card组件 semantic

Copy link

stackblitz bot commented Aug 13, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Aug 13, 2024

👁 Visual Regression Report for PR #50390 Passed ✅

🎯 Target branch: master (2f64ecf)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Preview is ready

Copy link

pkg-pr-new bot commented Aug 13, 2024

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2f64ecf) to head (577280f).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #50390   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          751       751           
  Lines        13178     13178           
  Branches      3429      3429           
=========================================
  Hits         13178     13178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Hi @thinkasany. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

@github-actions github-actions bot closed this Aug 13, 2024
@Wxh16144 Wxh16144 reopened this Aug 13, 2024
@thinkasany thinkasany changed the title docs(card): add card semantic docs(card): add card semantic dom Aug 13, 2024
@thinkasany thinkasany changed the title docs(card): add card semantic dom docs(card): use card semantic-dom instead of table Aug 13, 2024
@afc163 afc163 merged commit b34d208 into ant-design:master Aug 13, 2024
73 of 81 checks passed
linxianxi pushed a commit to linxianxi/ant-design that referenced this pull request Aug 14, 2024
Co-authored-by: codefactor-io <support@codefactor.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants