Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Upload): should support name prop drilling #50652

Merged
merged 4 commits into from
Sep 14, 2024

Conversation

Wxh16144
Copy link
Member

@Wxh16144 Wxh16144 commented Aug 30, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

fix: #50643

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English <Upload /> support 'name' prop drilling
🇨🇳 Chinese 上传组件支持 name prop 透传

Copy link

stackblitz bot commented Aug 30, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Aug 30, 2024

👁 Visual Regression Report for PR #50652 Passed ✅

🎯 Target branch: feature (fa5d758)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Aug 30, 2024

Preview is ready

Copy link

socket-security bot commented Aug 30, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/rc-upload@4.8.1 None 0 80.3 kB afc163

🚮 Removed packages: npm/rc-upload@4.7.0

View full report↗︎

@Wxh16144
Copy link
Member Author

要作为 feature 么? @afc163

Copy link
Contributor

github-actions bot commented Aug 30, 2024

size-limit report 📦

Path Size
dist/antd.min.js 439.63 KB (+6 B 🔺)
dist/antd-with-locales.min.js 507.29 KB (+6 B 🔺)

Copy link

pkg-pr-new bot commented Aug 30, 2024

Copy link

cloudflare-workers-and-pages bot commented Aug 30, 2024

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: dec5b8d
Status: ✅  Deploy successful!
Preview URL: https://0990ca0d.ant-design.pages.dev
Branch Preview URL: https://wuxh-bump-rc-upload-4-8-0.ant-design.pages.dev

View logs

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fa5d758) to head (dec5b8d).
Report is 1 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #50652   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          762       762           
  Lines        13497     13497           
  Branches      3507      3507           
=========================================
  Hits         13497     13497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Aug 30, 2024

对,作为 feature。

@afc163 afc163 closed this Aug 30, 2024
@Wxh16144 Wxh16144 reopened this Aug 30, 2024
@Wxh16144 Wxh16144 changed the base branch from master to feature August 30, 2024 08:34
@Wxh16144
Copy link
Member Author

对,作为 feature。

就这个 pr 改目标分支吧,等一波 ci 看看

@Wxh16144 Wxh16144 changed the title chore(deps): bump rc-upload to 4.8.0 feat(Upload): support name prop Aug 30, 2024
@Wxh16144 Wxh16144 changed the title feat(Upload): support name prop WIP feat(Upload): support name prop Aug 30, 2024
@Wxh16144 Wxh16144 changed the base branch from feature to master September 5, 2024 06:40
@Wxh16144
Copy link
Member Author

Wxh16144 commented Sep 5, 2024

对,作为 feature。

name 本来就支持,不用作为 feature ,当作一个 bug 修复,我在这里解释了一下 react-component/upload#576 (comment)

@Wxh16144 Wxh16144 changed the title WIP feat(Upload): support name prop fix(Upload): should support name prop drilling Sep 5, 2024
@Wxh16144
Copy link
Member Author

对,作为 feature。

name 本来就支持,不用作为 feature ,当作一个 bug 修复,我在这里解释了一下 react-component/upload#576 (comment)

感觉还是得改成 feature 分支合适... (就这样定吧,有问题方便回滚)

@Wxh16144 Wxh16144 changed the base branch from master to feature September 13, 2024 03:30
@afc163 afc163 merged commit b6edef3 into feature Sep 14, 2024
60 checks passed
@afc163 afc163 deleted the wuxh/bump-rc-upload_4.8.0 branch September 14, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Upload component's name attribute isn't reflecting on the input tag.
2 participants