Lazy set moment locale #8785
Merged
Lazy set moment locale #8785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afc163
reviewed
Dec 29, 2017
components/locale-provider/ar_EG.tsx
Outdated
| uploadError: 'مشكلة فى الرفع', | ||
| previewFile: 'استعرض الملف', | ||
| }, | ||
| }; |
afc163
reviewed
Dec 29, 2017
components/locale-provider/index.tsx
Outdated
| this.componentDidUpdate(); | ||
| } | ||
|
|
||
| componentWillReceiveProps() { | ||
| this.setMomentLocale(); |
yesmeck
force-pushed
the
lazy-set-moment-locale
branch
6 times, most recently
from
941a20d to
422d79c
Compare
|
原来的测试没测到这部分。 |
yesmeck
force-pushed
the
lazy-set-moment-locale
branch
from
422d79c to
1dec931
Compare
Codecov Report
@@ Coverage Diff @@
## master #8785 +/- ##
=========================================
- Coverage 85.32% 85.3% -0.02%
=========================================
Files 227 194 -33
Lines 4696 4683 -13
Branches 1376 1384 +8
=========================================
- Hits 4007 3995 -12
+ Misses 689 688 -1
Continue to review full report at Codecov.
|
afc163
reviewed
Jan 1, 2018
components/locale-provider/fr_FR.tsx
Outdated
| import Pagination from 'rc-pagination/lib/locale/fr_FR'; | ||
| import DatePicker from '../date-picker/locale/fr_FR'; | ||
| import TimePicker from '../time-picker/locale/fr_FR'; | ||
| import Calendar from '../calendar/locale/fr_FR'; | ||
|
|
||
| export default { | ||
| locale: 'fr', | ||
| setMomentLocale() { moment.locale('fr'); }, |
There was a problem hiding this comment.
这两个字符串如果都是一样的话，setMomentLocale 可以在 LocaleProvider 里写。
There was a problem hiding this comment.
用于时间组件，如 DatePicker 内，强行设置 moment.locale，以应对 value 里面的 locale 与 LocaleProvider 的 locale 不一致的情况。
There was a problem hiding this comment.
奥，那这个 localeCode 就是 moment 的 locale 表示。
yesmeck
force-pushed
the
lazy-set-moment-locale
branch
2 times, most recently
from
e1ef97c to
00c2ca5
Compare
yesmeck
commented
Jan 4, 2018
| componentDidUpdate() { | ||
| const { locale } = this.props; | ||
| changeConfirmLocale(locale && locale.Modal); | ||
| } | ||
|
|
||
| componentWillUnMount() { | ||
| componentWillUnmount() { |
yesmeck
force-pushed
the
lazy-set-moment-locale
branch
2 times, most recently
from
7511474 to
3d69f4e
Compare
yesmeck
force-pushed
the
lazy-set-moment-locale
branch
from
3d69f4e to
bdf6016
Compare
yesmeck
force-pushed
the
lazy-set-moment-locale
branch
from
bdf6016 to
303a9e8
Compare
afc163
approved these changes
Jan 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8662 #8816