Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore manifest files without version property #49

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

nekomeowww
Copy link

Description

  • Generally, this should not be a problem when bumpping up a single module without version, and it is meaningless to have a single module without version when using bumpp
  • However, for monorepos, since -r or recursive option will use current git version as current version, once some modules are marked as private without version specified in monorepo, current implementation will append the version property to the manifest (e.g. package.json) and produce unexpected outcomes.
  • This PR suggest to skip the modification if version is not set.

Linked Issues

Additional context

Optional version if not publishing: https://docs.npmjs.com/cli/v10/configuring-npm/package-json#version

Signed-off-by: Neko Ayaka <neko@ayaka.moe>
Signed-off-by: Neko Ayaka <neko@ayaka.moe>
@nekomeowww nekomeowww changed the title Dev/ignore without version feat: ignore manifest files without version property Oct 9, 2024
@antfu antfu merged commit 24c49a5 into antfu-collective:main Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants