Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pkg.pr.new gh action #230

Merged
merged 9 commits into from
Aug 15, 2024

Conversation

userquin
Copy link
Member

@userquin userquin commented Aug 14, 2024

Description

This PR adds pkg.pr.new as dev dependency, we need to register ni here: https://github.com/apps/pkg-pr-new (I don't have admin privileges on ni repo)

Linked Issues

Additional context

@userquin
Copy link
Member Author

/pkg-pr-new

package.json Outdated
@@ -6,13 +6,13 @@
"description": "Use the right package manager",
"author": "Anthony Fu <anthonyfu117@hotmail.com>",
"license": "MIT",
"homepage": "https://github.com/antfu-collective/ni#readme",
"homepage": "https://github.com/antfu/ni#readme",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we change back on this?

Copy link
Member Author

@userquin userquin Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing some test about using --compact

Copy link
Member Author

@userquin userquin Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Will revert this tmr, or feel free to revert changes yourself.

I asked Moha to help us with the behaviour:

  • release on every commit on main (?)
  • release on any pr using /pgk-pr-new or some other comment (like vite ecosytem-ci)

Release on every PR commit and main branch (excluding tags)
Copy link

pkg-pr-new bot commented Aug 15, 2024

commit: 46604ca

pnpm add https://pkg.pr.new/antfu-collective/ni/@antfu/ni@230

Open in Stackblitz

@userquin
Copy link
Member Author

We can also remove the dev dependency, removing it... dont merge yet

@userquin userquin merged commit 06edcd5 into main Aug 15, 2024
4 checks passed
@userquin userquin deleted the userquin/chore-update-pr.new-action branch August 15, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants