feat: add --sort option
#42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorts the output by the most or least outdated (decided by targetVersionTime)
antfu
reviewed
Sep 20, 2022
src/cli.ts
Outdated
| type: 'boolean', | ||
| describe: 'sort by most outdated', | ||
| }) | ||
| .option('sortReversed', { |
There was a problem hiding this comment.
Instead of two options, I prefer to have one sort option like:
--sort time-asc
--sort time-desc
--sort diff-asc
--sort diff-desc
There was a problem hiding this comment.
Check it again! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch adds the
--sortoption that acceptstime-asc,time-desc,diff-ascordiff-desc. And sorts the output by latesttargetVersionTimeor greatest difference ofcurrentVersionTimeandtargetVersionTime.Linked Issues
Fixes #33
Additional context