Adding icon purpose to nuxt config #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezlya
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Thank you @dlutton looks like nuxt-community/pwa-module#259 is closed. Bumping nuxt version and merging this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #163
Please note: This is not ready to be merged in.
nuxt-community/pwa-module#259
This is pending a release by the nuxt pwa module as the feature has already been merged into the master branch. Once they do this, we can update the dependency version in package.json and merge this in.
I did test this using a dependency of
"@nuxtjs/pwa": "github:nuxt-community/pwa-module"within package.json to pull in the latest from their master branch and tested on lighthouse which was successful.