Upstream patch: fix memory leak issue with diff protocol #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From: #1019
broadcastDiffLayers is not properly closed, the memory accumulates too many resources and causes OOM.
Rationale
broadcastDiffLayers
will be started inNewPeer
; need to callpeer.Close
whenRunPeer
fails. otherwise, this goroutine will not be closed.Example
panic.log
Changes
Notable changes: