Fix OSGi imports #3675
Merged
Fix OSGi imports #3675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
org.antlr.v4.gui is only used for backwards compatibility, but the manifest generated by upgraded maven-bundle-plugin generates an Import-Package requirement. This breaks the ability to load antlr4-runtime in an OSGi enviroment, when nothing provides org.antlr.v4.gui. Fix this by specifying resultion as optional. Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
This was referenced Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.antlr.v4.gui is only used for backwards compatibility, but the
manifest generated by upgraded maven-bundle-plugin generates an
Import-Package requirement. This breaks the ability to load
antlr4-runtime in an OSGi enviroment, when nothing provides
org.antlr.v4.gui.
Fix this by specifying resultion as optional.
Signed-off-by: Robert Varga robert.varga@pantheon.tech