Improve ExternalProject cmake file #3697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Adam <dev@robert-adam.de>
|
Ah whoops - on a fresh run, this will now error because the include dir does not exist yet during configure time. I'll fix this and force-push the last commit to include the fix. |
Krzmbrzl
force-pushed
the
improve-external-project-cmake-file
branch
from
0e14115
to
0a2e02b
Compare
By directly associating the defined antlr_* targets with the respective include directories, we make sure that any user that links against one of these targets, automatically has the necessary directories in their include path as well (without the need to explicitly specify them) as cmake will transitively propagate the interface include dirs to the linked-to target. Signed-off-by: Robert Adam <dev@robert-adam.de>
Krzmbrzl
force-pushed
the
improve-external-project-cmake-file
branch
from
0a2e02b
to
5059801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small improvements to the CMake file used to setup the cpp runtime
as an externa project in cmake.
The first commit just silences a warning in newer cmake versions, whereas the latter
ensures that a user does not have to take care of setting up the correct include directories
themselves. Linking to either
antl4_staticorantlr4_sharedwill now automaticallypopulate the include directories of the target these are linked to.