Ensure that only the tokens needed are fetched #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tristan Swadell <tswadell@google.com>
jcking
reviewed
May 18, 2022
|
Seems harmless enough and if it's mimicking C++ seems OK. Is the continuous integration system down @ericvergnaud ? |
|
There are some problems with self-hosted CI again on not Windows platforms. |
|
@ericvergnaud can you kick the CI? Seems like github actions, at least self hosted, are unreliable. I guess that means that if we bought some fancy server in the cloud it we have the same problem right? |
|
They are already fine at least here: #3725. Is it possible just to restart the build? |
Yes, I guess it's more reliable and preferable option. |
|
I restarted failed jobs. |
|
oh and now it says all fine. that was fast. maybe too fast. haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Go and Java runtimes to match the C++ runtime for syncing to only the tokens needed
to read the text from the supplied interval.
The
fill()methods search for EOF as a signal to conclude the token syncing; however, when thereis an errant input, EOF may be missing and this can result in
fill()re-reading the entire token streamfor each error encountered in the input. As such
fill()has been replaced withsync()calls whichprovide equivalent functionality.
Signed-off-by: Tristan Swadell tswadell@google.com