Swift runtime tests run on Windows! #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
KvanTTT
force-pushed
the
swift-on-windows
branch
15 times, most recently
from
2c34653
to
9a20e5b
Compare
Also, it seems faster: https://stackoverflow.com/a/46174300/1046374 Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Add Swift binaries to .gitignore Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Print exception info to console Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Fix build warnings Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
KvanTTT
force-pushed
the
swift-on-windows
branch
5 times, most recently
from
46c71fa
to
552c71a
Compare
|
Yeah, I'm not sure that github has gotten their Mac support to work very well but @ericvergnaud might have more information since he knows the set up. |
KvanTTT
force-pushed
the
swift-on-windows
branch
2 times, most recently
from
aa00223
to
3bb4415
Compare
|
Now it's ready for review. DCO is failed because I have one commit from another machine, but all CircleCI tests are green, including tests for Swift. |
|
Ok, I will likely get to this tomorrow as my brain is stuck elsewhere. This will give @ericvergnaud I chance to comment on Mac tests. |
|
Sure, no rush. Anyway, I haven't touched Mac pipelines. It can be removed later. |
antlr-exec property is actual for all runtimes, not only Python Simplify C++ runtime tester (use MSBuild value from PATH for Windows) Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
parrt
reviewed
Jul 3, 2022
| @@ -10,5 +8,4 @@ sudo apt-get update; \ | |||
| sudo apt-get update && \ | |||
| sudo apt-get install -y dotnet-sdk-3.1 | |||
| export PATH=$PATH:~/.dotnet | |||
| echo "done installing .Net SDK" | |||
There was a problem hiding this comment.
Probably OK, but it looks like this is missing a new line on the end, which annoys UNIX.
|
Looks absolutely amazing! Wow Swift on circleci :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pthread_mutex_tMake Swift runtime compilable under Windows (yes, it's possible) #3755@parrt I think it makes sense to disable MacOS agent since it's not reliable and it still doesn't work. I fixed Swift runtime tests and now they work on Linux (CircleCI). Also, Swift runtime tests work on Windows but only from IntelliJ (I haven't found out why they don't work from maven).