Fully qualify std::move invocations to fix -Wunqualified-std-cast-call #4101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang implemented a warning last year to detect bare `move` and `forward` calls, as they have the potential to be error prone: llvm/llvm-project@70b1f6d. This warning should be available in clang-15. Signed-off-by: Jordan Rupprecht <rupprecht@google.com>
|
Updated the commit with DCO |
|
@hzeller @mike-lischke this seems like a reasonable change as it's just cleaning up right? |
|
LGTM
…On Wed, Feb 8, 2023, 15:24 Terence Parr ***@***.***> wrote:
@hzeller <https://github.com/hzeller> @mike-lischke
<https://github.com/mike-lischke> this seems like a reasonable change as
it's just cleaning up right?
—
Reply to this email directly, view it on GitHub
<#4101 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABCNCLANLBAYIS4W3HJQG3WWQTLLANCNFSM6AAAAAAUVYXH2Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang implemented a warning last year to detect bare
moveandforwardcalls, as they have the potential to be error prone: llvm/llvm-project@70b1f6d. This warning should be available in clang-15.