fix: Some code that should have been destined for /v4 was instead put… #4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in to the root (pre v4) files - Incorporate an interative tree walker - Expose Reset() and String() in lexer/token and add test Signed-off-by: Jim.Idle <jimi@idle.ws>
|
thanks! |
jimidle
pushed a commit
to jimidle/antlr4
that referenced
this pull request
Mar 28, 2023
… in to the root (pre v4) files (antlr#4154) - Incorporate an interative tree walker - Expose Reset() and String() in lexer/token and add test Signed-off-by: Jim.Idle <jimi@idle.ws>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Code that should have gone to the /v4 files was instead placed in to the root (pre v4) files
This PR merely copies the changes in to the correct place - code has already been reviewed.
@parrt - please merge so I can then proceed with removing the pre-v4 files from the repo