feat: More reasonable wins in performance #4224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another small gain, but for one good parser this goes from 90ms to 64ms (for 16 large files) so it won't make a lot of difference for poor parser, but good ones will see a nice kick here Signed-off-by: Jim.Idle <jimi@idle.ws>
o Uses reflection to check that the tree structure is all correct o Disables test that uses superClass as this basically doesn't work/isn't a concept in Go. Signed-off-by: Jim.Idle <jimi@idle.ws>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Removes embedding by pointers in parser rule contexts.
This is a reasonable win for good parsers, especially if they can use SLL.
Also includes some final reformats to get the code 100% Go 1.20 formatted.
@parrt This is a good one to get in to the next release if the Google parsers are well implemented - especially if they are SLL parsing