Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change closureCheckingStopState from recursive to iterative #4256

Merged
merged 1 commit into from
May 5, 2023
Merged

Change closureCheckingStopState from recursive to iterative #4256

merged 1 commit into from
May 5, 2023

Conversation

jimidle
Copy link
Collaborator

@jimidle jimidle commented May 5, 2023

feat: closureCheckingStopState is now an iterative function

  • Recursive function retained but will be removed next release
  • Improves stack usage on poor grammars
  • Provides general speed up for all grammars

First of a few potential changes to use iteration instead of recursion

@jimidle
Copy link
Collaborator Author

jimidle commented May 5, 2023

@parrt Another ready for merge please :)

@parrt parrt added this to the 4.12.1 milestone May 5, 2023
@parrt parrt added the target:go label May 5, 2023
@parrt parrt merged commit 8943efa into antlr:dev May 5, 2023
@jimidle jimidle deleted the feature/iterative branch May 5, 2023 00:43
@admin-token-bot admin-token-bot mentioned this pull request Jul 7, 2024
Open
@bhaskar-allam bhaskar-allam mentioned this pull request Oct 25, 2024
Open
@ThatGhostToast ThatGhostToast mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
target:go
Projects
None yet
Milestone
4.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jimidle @parrt